From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0070946A45; Tue, 24 Jun 2025 14:30:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A58640A89; Tue, 24 Jun 2025 14:29:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7D22940A6D for ; Tue, 24 Jun 2025 14:29:53 +0200 (CEST) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55O5BUeQ031343; Tue, 24 Jun 2025 05:29:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=q tKHL9cWtujy6zf3/trQ3sngPRnpm99sCz00WRiebjg=; b=hM6k6t/8u56zTE7J3 0X0vnDd4aKh7XeRG/Ywk1lUClP/wZPsGP5Q45C4SgSrPbL5Nj5nwpqsR0x6fssss LoDEclhMluehQIc++/1z7cGhlHBpnsMUEDw2we8f8gP61qPtF39egu4ByrODybc7 JS6SC5dworbgmQF4++zMduUmmHr6fLBWswY5jOTRLyPynghlwXwhU7vcrD6eaX6z 8sQ0FI2PZaNHxcvcVMliMOipEFtP80/+hvWzt7r4QosCmWcMBHepXfckyQ2MUnnU ZP34aOu47i0MM2qTJ5LohFTEFYl+fZxr8UT8ny2vMWdahYE++KyZcITgrBrSnn9L 8nVwA== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 47fnnbru0t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jun 2025 05:29:52 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Jun 2025 05:29:51 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 24 Jun 2025 05:29:51 -0700 Received: from cavium-optiplex-3070-BM15.. (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 6A2393F7063; Tue, 24 Jun 2025 05:29:49 -0700 (PDT) From: Tomasz Duszynski To: CC: , , , , , Subject: [PATCH v4 5/7] test/pmu: enable fast test Date: Tue, 24 Jun 2025 14:29:28 +0200 Message-ID: <20250624122930.1783177-6-tduszynski@marvell.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250624122930.1783177-1-tduszynski@marvell.com> References: <20250620120551.613148-1-tduszynski@marvell.com> <20250624122930.1783177-1-tduszynski@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDEwNSBTYWx0ZWRfX5j0FypdnoZIe zqkpb9amADo4Dhz2hqhJ5ogaa1WBCYULRGcJoGeCueAFtiOIVjAQe5DVdGL27RfXwLPUBO+ueNK DUOjLI9La3zFGIvGSi4814qF4OluymP3nSoRNNkLLr9X3odHzV5lOGTrs0Xrfod1l01tMNJxURC sXn0N0pFi6t0Ulzx+i1OdhU1qeGbIC40UYNt2vtUIWE8r5ZNLdQLrsEInQ3HP6YLW5kvvabmthH mzhU45InkYG9Kdkx1UXuf+4Z6bSGmoaZywiH05rRe8yaL4SOpqr8t2Mupa4/eHYduC0aaIgZraP LuRaYfrFES4mxgH0qJxXWSxmxc3Oxgh2hGxTRcYlPW88Jws1ldtOAQ1qbHpVQSzjvWXhe1ZtkGn v3q5ZGP5p3BTsmgUcupNZNAJjsqr8ZLtfFGmq8C18Cng+5loVOZTipU3/kOdPbw1IQ9mngi8 X-Authority-Analysis: v=2.4 cv=IPECChvG c=1 sm=1 tr=0 ts=685a9a40 cx=c_pps a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=M5GUcnROAAAA:8 a=Smj5QJchIq_J3ojvSm4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-GUID: tT_Z1nu-ufjihdigcRc7yV74hMiZA7E0 X-Proofpoint-ORIG-GUID: tT_Z1nu-ufjihdigcRc7yV74hMiZA7E0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_04,2025-06-23_07,2025-03-28_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org DPDK test suite provides much broader architecture coverage than what can be tested locally so enable the test to help identify potential issues. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 51 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/app/test/test_pmu.c b/app/test/test_pmu.c index 10513bf9c9..bc41833eef 100644 --- a/app/test/test_pmu.c +++ b/app/test/test_pmu.c @@ -2,10 +2,47 @@ * Copyright(C) 2025 Marvell International Ltd. */ +#include +#include +#include + #include #include "test.h" +#define PERF_EVENT_PARANOID_PATH "/proc/sys/kernel/perf_event_paranoid" + +static bool perf_allowed_quirk(void) +{ + int level, ret; + FILE *fp; + + fp = fopen(PERF_EVENT_PARANOID_PATH, "r"); + if (!fp) + return false; + + ret = fscanf(fp, "%d", &level); + fclose(fp); + if (ret != 1) + return false; + + /* On vanilla Linux the default perf_event_paranoid level is 2, which allows non-privileged + * processes to access performance counters. + * + * Debian / Ubuntu and their derivatives apply patches that introduce + * additional paranoia levels: + * + * - Debian adds level 3, which restricts access to perf_event_open() for + * monitoring other processes, but still allows unprivileged self-monitoring. + * See: https://lore.kernel.org/all/1469630746-32279-1-git-send-email-jeffv@google.com/ + * - Ubuntu adds level 4 (which is also the default), completely disabling perf_event_open() + * for unprivileged users—effectively disabling self-monitoring. + * + * That said, check below should be sufficient to enable this test on most kernels. + */ + return level < 4; +} + static int test_pmu_read(void) { @@ -24,6 +61,9 @@ test_pmu_read(void) return TEST_SKIPPED; } + if (!perf_allowed_quirk()) + return TEST_SKIPPED; + if (rte_pmu_init() < 0) return TEST_FAILED; @@ -33,7 +73,12 @@ test_pmu_read(void) rte_pmu_fini(); - return val ? TEST_SUCCESS : TEST_FAILED; + /* rte_pmu_read() returns zero if it can't read perf counter. Thus series of zeros doesn't + * necessarily mean the counter is actually zero. It might just signal a problem with setup + * itself. So skip test to avoid testing failure and leave it to user to interpret this + * outcome. + */ + return val ? TEST_SUCCESS : TEST_SKIPPED; } static struct unit_test_suite pmu_tests = { @@ -52,6 +97,4 @@ test_pmu(void) return unit_test_suite_runner(&pmu_tests); } -/* disabled because of reported failures, waiting for a fix - * REGISTER_FAST_TEST(pmu_autotest, true, true, test_pmu); - */ +REGISTER_FAST_TEST(pmu_autotest, true, true, test_pmu); -- 2.34.1