From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A7A046A45; Tue, 24 Jun 2025 14:30:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2596C40B99; Tue, 24 Jun 2025 14:30:01 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3798740B94 for ; Tue, 24 Jun 2025 14:29:59 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OBv8rM009262; Tue, 24 Jun 2025 05:29:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=J 0OKrcg7d1Ljahf089tMgNuat3ruvBtaiRh7alnR/Xs=; b=TNWnn2m96G85p3fWi lEG6tkrSJBLseXik/+01T8PttXT0LPTtv7eQL4fnDdUyPPZjxRNsqjqFdFbxJIJA WyE1nYlW6m0GOKY30+Zb1KSyUq2kx1Sh2CQtPYHeIfQmd0ykikOpyD6h16Polun7 hscVW6Nsd7bfIhUuTVsljHCvoVM3oNr8p5eVOXCmJyJsSZ9vs6ZKjDOlDQKlysu3 jxKnvlaPsGWwhJEEVSMZFYnWjCfWgojJnsDyl7LHMSEceiS9kMrH8bXJ65yoWsKk UZVRPk/cpCINGvRrPQs7q48Xqvt3dCxM8tJ1mNyicFghmXjGDfJsiVKP0fHBd/KE 9BU3w== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 47fgsqsc1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Jun 2025 05:29:58 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 24 Jun 2025 05:29:57 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 24 Jun 2025 05:29:57 -0700 Received: from cavium-optiplex-3070-BM15.. (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 0C8993F705E; Tue, 24 Jun 2025 05:29:54 -0700 (PDT) From: Tomasz Duszynski To: CC: , , , , , Subject: [PATCH v4 7/7] lib/pmu: fix out-of-bound access Date: Tue, 24 Jun 2025 14:29:30 +0200 Message-ID: <20250624122930.1783177-8-tduszynski@marvell.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250624122930.1783177-1-tduszynski@marvell.com> References: <20250620120551.613148-1-tduszynski@marvell.com> <20250624122930.1783177-1-tduszynski@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: NH0i25Q6H22ZvxWz0yub9LleylbvDu7L X-Authority-Analysis: v=2.4 cv=DOqP4zNb c=1 sm=1 tr=0 ts=685a9a46 cx=c_pps a=rEv8fa4AjpPjGxpoe8rlIQ==:117 a=rEv8fa4AjpPjGxpoe8rlIQ==:17 a=6IFa9wvqVegA:10 a=M5GUcnROAAAA:8 a=rsDlWQ7q-kAZFu0dnB0A:9 a=OBjm3rFKGHvpk9ecZwUJ:22 X-Proofpoint-ORIG-GUID: NH0i25Q6H22ZvxWz0yub9LleylbvDu7L X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI0MDEwNSBTYWx0ZWRfX3iZ/nVy9ndL3 xHYKWaIUJvunKlTiykDhabdqqLPI7grQ6wRHTteLeh0n+lO7C6G0jvHH5to3lm8CfsRB7T8YmNS o99ITpygiC5JRQXbHp9dAcrSdh/GzragDqKP3G4EsxV2oGAq9SaClyl+SZUE2QgOvwxi+1THMmN 64RDA9HWi5gUu8Y+9G3cjJfXJuSEIeBxlzx8nLHW12838RIEJB2IeA5Rh10HDG27cc9yPWUJ1pk F87vhXb57GwMNi8QlCIMrIM5NjKa3CM4oLngTVXRfNYnV/Ir+PkEMInnLloNuoRk/nqvharx8Av 2vOWr/K0aWqfgAUFy2QMOYQZrixqP26eg974dlkcoMyVd5rUaV/BGcfB4l3kxWiig/0XzcnfQ5R ghH0Im/cvU1cO09kf/AxGfeqdG1/4Yq4TEzxPZP5rUz24bbOBxjXWWDY5zfd9S1BtJC6vNgB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-24_04,2025-06-23_07,2025-03-28_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Make sure that out-of-bound access does not happen by saving one byte in buffer for NUL terminator. Fixes: a8926a65ad1d ("pmu: support Arm") Fixes: 960c43184c4d ("pmu: introduce library for reading PMU events") Cc: tduszynski@marvell.com Signed-off-by: Tomasz Duszynski --- lib/pmu/pmu.c | 2 +- lib/pmu/pmu_arm64.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/pmu/pmu.c b/lib/pmu/pmu.c index 742829cf9d..8960faa7d0 100644 --- a/lib/pmu/pmu.c +++ b/lib/pmu/pmu.c @@ -126,7 +126,7 @@ get_event_config(const char *name, uint64_t config[3]) if (fp == NULL) return -errno; - ret = fread(buf, 1, sizeof(buf), fp); + ret = fread(buf, 1, sizeof(buf) - 1, fp); if (ret == 0) { fclose(fp); diff --git a/lib/pmu/pmu_arm64.c b/lib/pmu/pmu_arm64.c index 2c40b5f702..f3a817b42f 100644 --- a/lib/pmu/pmu_arm64.c +++ b/lib/pmu/pmu_arm64.c @@ -24,12 +24,13 @@ read_attr_int(const char *path, int *val) if (fd == -1) return -errno; - ret = read(fd, buf, sizeof(buf)); + ret = read(fd, buf, sizeof(buf) - 1); if (ret == -1) { close(fd); return -errno; } + buf[ret] = '\0'; *val = strtol(buf, NULL, 10); close(fd); -- 2.34.1