Re: [PATCH v2 2/2] net/mlx5: enhance log file path

[Dariusz Sosnowski <dsosnowski@nvidia.com>]

Hi Yang,

This patch breaks compilation on Windows:
https://lab.dpdk.org/results/dashboard/testruns/logs/1600918/

The problem is that mlx5_rxtx.c is used on both Linux and Windows.

Would you be able to fix the patch?
I suggest to do the following:

- Declare a function mlx5_os_debug_dump_file_open() in mlx5.h.
- Define it in drivers/net/mlx5/linux/mlx5_os.c.
  Here the existing logic from the patch can be used to open the file.
- Define it in drivers/net/mlx5/windows/mlx5_os.c.
  Here we can rely on rte_eal_get_runtime_dir() only,
  since MLX5_SYSTEM_LOG_DIR is not defined correctly to work
  on Windows as well.
  (see https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/access-waccess?view=msvc-170)
- Replace the opening of the file in mlx5_dump_debug_information()
  with mlx5_os_debug_dump_file_open().

Best regards,
Dariusz Sosnowski

On Wed, Jun 04, 2025 at 06:54:05AM +0000, Maayan Kashani wrote:
> Hi, Yang,
> Thanks for contributing,
> There are some failing CI tests.
> Can you fix it?
>  https://patches.dpdk.org/project/dpdk/patch/20250321132750.4237-2-ming.1.yang@nokia-sbell.com/
> 
> Regards,
> Maayan Kashani
> 
> > -----Original Message-----
> > From: Moses Young <mosesyyoung@gmail.com>
> > Sent: Monday, 12 May 2025 13:13
> > To: Yang Ming <ming.1.yang@nokia-sbell.com>; dev@dpdk.org
> > Cc: Bing Zhao <bingz@nvidia.com>; Dariusz Sosnowski
> > <dsosnowski@nvidia.com>; stephen@networkplumber.org;
> > julien.meunier@nokia.com
> > Subject: Re: [PATCH v2 2/2] net/mlx5: enhance log file path
> > 
> > External email: Use caution opening links or attachments
> > 
> > 
> > > Hi Experts,
> > >
> > > is there any chance to review and accept this patch?
> > >
> > > Brs,
> > >
> > > Yang Ming
> > >