Re: [RFC 14/18] net/hinic3: add Rx/Tx functions

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 18 Apr 2025 17:06:00 +0800
Feifei Wang <wff_light@vip.163.com> wrote:

> From: Feifei Wang <wangfeifei40@huawei.com>
> 
> This patch add package sending and receiving function codes.
> 
> Signed-off-by: Feifei Wang <wangfeifei40@huawei.com>
> Signed-off-by: Yi Chen <chenyi221@huawei.com>
> Reviewed-by: Xin Wang <wangxin679@h-partners.com>
> ---

This code has lots of places where __rte_unused is added, but
the arguments are used.

diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c
index 51dd5f76fc..7faf3c6dcc 100644
--- a/drivers/net/hinic3/hinic3_ethdev.c
+++ b/drivers/net/hinic3/hinic3_ethdev.c
@@ -677,7 +677,7 @@ hinic3_reset_tx_queue(struct rte_eth_dev *dev)
 static int
 hinic3_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qid, uint16_t nb_desc,
 		      unsigned int socket_id,
-		      __rte_unused const struct rte_eth_rxconf *rx_conf,
+		      const struct rte_eth_rxconf *rx_conf,
 		      struct rte_mempool *mp)
 {
 	struct hinic3_nic_dev *nic_dev;
@@ -898,7 +898,7 @@ hinic3_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qid, uint16_t nb_desc,
 static int
 hinic3_tx_queue_setup(struct rte_eth_dev *dev, uint16_t qid, uint16_t nb_desc,
 		      unsigned int socket_id,
-		      __rte_unused const struct rte_eth_txconf *tx_conf)
+		      const struct rte_eth_txconf *tx_conf)
 {
 	struct hinic3_nic_dev *nic_dev;
 	struct hinic3_hwdev *hwdev;
@@ -1127,8 +1127,8 @@ hinic3_tx_queue_release(struct rte_eth_dev *dev, uint16_t queue_id)
  * 0 on success, non-zero on failure.
  */
 static int
-hinic3_dev_rx_queue_start(__rte_unused struct rte_eth_dev *dev,
-			  __rte_unused uint16_t rq_id)
+hinic3_dev_rx_queue_start(struct rte_eth_dev *dev,
+			  uint16_t rq_id)
 {
 	struct hinic3_rxq *rxq = NULL;
 	int rc;
@@ -1168,8 +1168,8 @@ hinic3_dev_rx_queue_start(__rte_unused struct rte_eth_dev *dev,
  * 0 on success, non-zero on failure.
  */
 static int
-hinic3_dev_rx_queue_stop(__rte_unused struct rte_eth_dev *dev,
-			 __rte_unused uint16_t rq_id)
+hinic3_dev_rx_queue_stop(struct rte_eth_dev *dev,
+			 uint16_t rq_id)
 {
 	struct hinic3_rxq *rxq = NULL;
 	int rc;
@@ -1199,8 +1199,8 @@ hinic3_dev_rx_queue_stop(__rte_unused struct rte_eth_dev *dev,
 }
 
 static int
-hinic3_dev_tx_queue_start(__rte_unused struct rte_eth_dev *dev,
-			  __rte_unused uint16_t sq_id)
+hinic3_dev_tx_queue_start(struct rte_eth_dev *dev,
+			  uint16_t sq_id)
 {
 	struct hinic3_txq *txq = NULL;
 
@@ -1214,8 +1214,8 @@ hinic3_dev_tx_queue_start(__rte_unused struct rte_eth_dev *dev,
 }
 
 static int
-hinic3_dev_tx_queue_stop(__rte_unused struct rte_eth_dev *dev,
-			 __rte_unused uint16_t sq_id)
+hinic3_dev_tx_queue_stop(struct rte_eth_dev *dev,
+			 uint16_t sq_id)
 {
 	struct hinic3_txq *txq = NULL;
 	int rc;