From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E09546A65; Thu, 26 Jun 2025 23:50:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20BCE4021F; Thu, 26 Jun 2025 23:50:36 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id AB778400D5 for ; Thu, 26 Jun 2025 23:50:34 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-313eeb77b1fso1340744a91.1 for ; Thu, 26 Jun 2025 14:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1750974633; x=1751579433; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=da5y3jmroepuSJuY6+uNaLx6slWnwSlI2dz+fCQyzVQ=; b=2fcBRGs0P8wp4Pb6a3GHBkNQp1giL9/T5yrRM2OPdhmCmeEPxvM2HX/fk0urf/wjuZ qQx9zhepXeejOk6LnyirP/bSg51IAv/3Ts1xScXq4g/AWtrcjnqGdqXZEii5THp9G3Q9 XePQlaHi2OyVHoaBw9JSi4QYaH+597sOh+ISDqFujGvcBmvJ+ZwFFUk7vMuP1oVP5ccC 0CKJHYbOiaSz9SUbmKmS6SWIcO5akkoMVaAY8WeKkUBS/w29cdfU9vtuqjZTObEGqVSg Ce7nIux69iOv1+TrP9uzIm5NMHbtJ+mTv5iuuGXeieL5tYDZ0DdtjQk2j+9MaA8L+h2g JLcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750974633; x=1751579433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=da5y3jmroepuSJuY6+uNaLx6slWnwSlI2dz+fCQyzVQ=; b=IG5qPFDOKnAELIZUMq2bmXkxgaVcK2Cr/o3NiRnUYXdzbPZIahExcRF7X1sNw79Q73 ie0SsCCVErfOcdIbXdmM/xsqWQPMEzUGRSNzflQ92ZiWg6b/igjj3dncAzGPqENjehcN NNHOgaUwYqkNwsII9YDbA0Ez1c4vU/6VRrRe+mCGjYXUd9xY7bjAmK1mbzVGkepCFz7/ URkK3pI7QWAeqO+M58ps6wRSFjkjqw+EJgRyVx60tQnQpIzvg0Hw5uKpPEK/8vAo6f1f HS8glYakzfN+WPoxP7MCBfkWIQ8d4cJjtNQLqUn9mPiQ1bCnyqBE6EXI5d/ZVe6lyqW4 pwCA== X-Gm-Message-State: AOJu0YxfcqDy9/kB5pa1fUVbvUJljlgQYxMMaNwRqNGvuavo0H80Zwgt aDJyuR5cNZCwPO7+kY3rrlh0Ikxhdl2/125s64TUaE1WNKEW7cfULb4nCDb70fWP46dh3jbKPKv rm3JU X-Gm-Gg: ASbGncvZ3/+Mqi0ZbVv2QkfzSlr0bBM9rQljF58UKm04sZwt/3E7qvDzICXakfyfee0 K8TQhl/0hEH6ttqm0ZwUHCq1ch/VSSW219URD3/QTLH7QcLKNNs2y/mtUR5bwQL46VwedA8l4Mj prj/tYmCjDeQllJBb/A2cNWFuuvzE/Ox5hdpYyVFX7mvtn2DYfbOyzU1KDX+s9ORYMPiCrm7jt5 sIS6bnM6qnoIQ/Pk788KQ7FvlVjIfBuqughjPGWp/i/sreVljsQlKhHcZVf2T30SuYxzRC5CJ3d 4/pZE64I8VIHQiSQByRiYbmgbGF/d0qEpmInAj4dMXrT18Cq9fSmEhO301BLGs9w630zKNOsvgr Df20XrNVIsv2l9xGVhvyecRQWb3yGkzqjsBAJfWU= X-Google-Smtp-Source: AGHT+IEkRwyFEEG6U2hhjcgKI6CamW6FBelD//SzWcBbXLopAbV0BQ7ryVqsgc1PSluDbc/itoyPug== X-Received: by 2002:a17:90b:5345:b0:311:b3e7:fb31 with SMTP id 98e67ed59e1d1-318c8d2ba92mr876802a91.0.1750974633397; Thu, 26 Jun 2025 14:50:33 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb2e25b9sm610335ad.2.2025.06.26.14.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jun 2025 14:50:33 -0700 (PDT) Date: Thu, 26 Jun 2025 14:41:13 -0700 From: Stephen Hemminger To: Feifei Wang Cc: dev@dpdk.org, Yi Chen Subject: Re: [V2 00/18] add hinic3 pmd driver Message-ID: <20250626144113.1f1eae23@hermes.local> In-Reply-To: <20250625022827.3091-1-wff_light@vip.163.com> References: <20250418090621.9638-1-wff_light@vip.163.com> <20250625022827.3091-1-wff_light@vip.163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 25 Jun 2025 10:27:56 +0800 Feifei Wang wrote: > From: Yi Chen > > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (2): > net/hinic3: add dev ops > net/hinic3: add Rx/Tx functions > > Xin Wang (7): > net/hinic3: add basic header files > net/hinic3: add support for cmdq mechanism > net/hinic3: add NIC event module > net/hinic3: add context and work queue support > net/hinic3: add device initialization > net/hinic3: add MML and EEPROM access feature > net/hinic3: add RSS promiscuous ops > > Yi Chen (8): > net/hinic3: add hardware interfaces of BAR operation > net/hinic3: add eq mechanism function code > net/hinic3: add mgmt module function code > net/hinic3: add module about hardware operation > net/hinic3: add a NIC business configuration module > net/hinic3: add a mailbox communication module > net/hinic3: add FDIR flow control module > drivers/net: add hinic3 PMD build and doc files > > Yi Chen (1): > This patch adds some basic files to describe the hinic3 driver. > > .mailmap | 4 +- > MAINTAINERS | 6 + > doc/guides/nics/features/hinic3.ini | 9 + > doc/guides/nics/hinic3.rst | 51 + > doc/guides/nics/index.rst | 1 + > doc/guides/rel_notes/release_25_07.rst | 4 + > drivers/net/hinic3/base/hinic3_cmd.h | 231 ++ > drivers/net/hinic3/base/hinic3_cmdq.c | 978 +++++ > drivers/net/hinic3/base/hinic3_cmdq.h | 230 ++ > drivers/net/hinic3/base/hinic3_compat.h | 266 ++ > drivers/net/hinic3/base/hinic3_csr.h | 108 + > drivers/net/hinic3/base/hinic3_eqs.c | 721 ++++ > drivers/net/hinic3/base/hinic3_eqs.h | 98 + > drivers/net/hinic3/base/hinic3_hw_cfg.c | 240 ++ > drivers/net/hinic3/base/hinic3_hw_cfg.h | 121 + > drivers/net/hinic3/base/hinic3_hw_comm.c | 452 +++ > drivers/net/hinic3/base/hinic3_hw_comm.h | 366 ++ > drivers/net/hinic3/base/hinic3_hwdev.c | 573 +++ > drivers/net/hinic3/base/hinic3_hwdev.h | 177 + > drivers/net/hinic3/base/hinic3_hwif.c | 779 ++++ > drivers/net/hinic3/base/hinic3_hwif.h | 142 + > drivers/net/hinic3/base/hinic3_mbox.c | 1399 +++++++ > drivers/net/hinic3/base/hinic3_mbox.h | 199 + > drivers/net/hinic3/base/hinic3_mgmt.c | 392 ++ > drivers/net/hinic3/base/hinic3_mgmt.h | 121 + > drivers/net/hinic3/base/hinic3_nic_cfg.c | 1828 +++++++++ > drivers/net/hinic3/base/hinic3_nic_cfg.h | 1527 ++++++++ > drivers/net/hinic3/base/hinic3_nic_event.c | 433 +++ > drivers/net/hinic3/base/hinic3_nic_event.h | 39 + > drivers/net/hinic3/base/hinic3_wq.c | 148 + > drivers/net/hinic3/base/hinic3_wq.h | 109 + > drivers/net/hinic3/base/meson.build | 50 + > drivers/net/hinic3/hinic3_ethdev.c | 3866 ++++++++++++++++++++ > drivers/net/hinic3/hinic3_ethdev.h | 167 + > drivers/net/hinic3/hinic3_fdir.c | 1394 +++++++ > drivers/net/hinic3/hinic3_fdir.h | 398 ++ > drivers/net/hinic3/hinic3_flow.c | 1700 +++++++++ > drivers/net/hinic3/hinic3_flow.h | 80 + > drivers/net/hinic3/hinic3_nic_io.c | 828 +++++ > drivers/net/hinic3/hinic3_nic_io.h | 169 + > drivers/net/hinic3/hinic3_rx.c | 1099 ++++++ > drivers/net/hinic3/hinic3_rx.h | 356 ++ > drivers/net/hinic3/hinic3_tx.c | 1028 ++++++ > drivers/net/hinic3/hinic3_tx.h | 315 ++ > drivers/net/hinic3/meson.build | 33 + > drivers/net/hinic3/mml/hinic3_dbg.c | 171 + > drivers/net/hinic3/mml/hinic3_dbg.h | 160 + > drivers/net/hinic3/mml/hinic3_mml_cmd.c | 375 ++ > drivers/net/hinic3/mml/hinic3_mml_cmd.h | 131 + > drivers/net/hinic3/mml/hinic3_mml_ioctl.c | 215 ++ > drivers/net/hinic3/mml/hinic3_mml_lib.c | 136 + > drivers/net/hinic3/mml/hinic3_mml_lib.h | 276 ++ > drivers/net/hinic3/mml/hinic3_mml_main.c | 167 + > drivers/net/hinic3/mml/hinic3_mml_queue.c | 745 ++++ > drivers/net/hinic3/mml/hinic3_mml_queue.h | 256 ++ > drivers/net/hinic3/mml/meson.build | 45 + > drivers/net/meson.build | 1 + > 57 files changed, 25912 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/nics/features/hinic3.ini > create mode 100644 doc/guides/nics/hinic3.rst > create mode 100644 drivers/net/hinic3/base/hinic3_cmd.h > create mode 100644 drivers/net/hinic3/base/hinic3_cmdq.c > create mode 100644 drivers/net/hinic3/base/hinic3_cmdq.h > create mode 100644 drivers/net/hinic3/base/hinic3_compat.h > create mode 100644 drivers/net/hinic3/base/hinic3_csr.h > create mode 100644 drivers/net/hinic3/base/hinic3_eqs.c > create mode 100644 drivers/net/hinic3/base/hinic3_eqs.h > create mode 100644 drivers/net/hinic3/base/hinic3_hw_cfg.c > create mode 100644 drivers/net/hinic3/base/hinic3_hw_cfg.h > create mode 100644 drivers/net/hinic3/base/hinic3_hw_comm.c > create mode 100644 drivers/net/hinic3/base/hinic3_hw_comm.h > create mode 100644 drivers/net/hinic3/base/hinic3_hwdev.c > create mode 100644 drivers/net/hinic3/base/hinic3_hwdev.h > create mode 100644 drivers/net/hinic3/base/hinic3_hwif.c > create mode 100644 drivers/net/hinic3/base/hinic3_hwif.h > create mode 100644 drivers/net/hinic3/base/hinic3_mbox.c > create mode 100644 drivers/net/hinic3/base/hinic3_mbox.h > create mode 100644 drivers/net/hinic3/base/hinic3_mgmt.c > create mode 100644 drivers/net/hinic3/base/hinic3_mgmt.h > create mode 100644 drivers/net/hinic3/base/hinic3_nic_cfg.c > create mode 100644 drivers/net/hinic3/base/hinic3_nic_cfg.h > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.c > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.h > create mode 100644 drivers/net/hinic3/base/hinic3_wq.c > create mode 100644 drivers/net/hinic3/base/hinic3_wq.h > create mode 100644 drivers/net/hinic3/base/meson.build > create mode 100644 drivers/net/hinic3/hinic3_ethdev.c > create mode 100644 drivers/net/hinic3/hinic3_ethdev.h > create mode 100644 drivers/net/hinic3/hinic3_fdir.c > create mode 100644 drivers/net/hinic3/hinic3_fdir.h > create mode 100644 drivers/net/hinic3/hinic3_flow.c > create mode 100644 drivers/net/hinic3/hinic3_flow.h > create mode 100644 drivers/net/hinic3/hinic3_nic_io.c > create mode 100644 drivers/net/hinic3/hinic3_nic_io.h > create mode 100644 drivers/net/hinic3/hinic3_rx.c > create mode 100644 drivers/net/hinic3/hinic3_rx.h > create mode 100644 drivers/net/hinic3/hinic3_tx.c > create mode 100644 drivers/net/hinic3/hinic3_tx.h > create mode 100644 drivers/net/hinic3/meson.build > create mode 100644 drivers/net/hinic3/mml/hinic3_dbg.c > create mode 100644 drivers/net/hinic3/mml/hinic3_dbg.h > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_cmd.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_cmd.h > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_ioctl.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_lib.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_lib.h > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_main.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_queue.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_queue.h > create mode 100644 drivers/net/hinic3/mml/meson.build > Overall, the driver looks good. The only obvious serious problem is putting in unnecessary stubs which will cause applications to think functions are implemented that are not. Fix the comments and resubmit