From: Stephen Hemminger <stephen@networkplumber.org>
To: Oleksandr Kolomeiets <okl-plv@napatech.com>
Cc: dev@dpdk.org, mko-plv@napatech.com, sil-plv@napatech.com,
ckm@napatech.com
Subject: Re: [PATCH v1 1/4] net/ntnic: implement start/stop for Rx/Tx queues
Date: Sun, 29 Jun 2025 10:50:42 -0700 [thread overview]
Message-ID: <20250629105042.00929828@hermes.local> (raw)
In-Reply-To: <20250620112707.294596-2-okl-plv@napatech.com>
On Fri, 20 Jun 2025 13:27:04 +0200
Oleksandr Kolomeiets <okl-plv@napatech.com> wrote:
> The following functions exported by the driver were stubs
> which merely changed the status flags:
> * rx_queue_start
> * rx_queue_stop
> * tx_queue_start
> * tx_queue_stop
>
> Proper implementation was added to control queues's state.
>
> Signed-off-by: Oleksandr Kolomeiets <okl-plv@napatech.com>
Since these were broken (and now fixed), you should add a Fixes: tag to this patch.
next prev parent reply other threads:[~2025-06-29 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 11:27 [PATCH v1 0/4] net/ntnic: implement start, stop and deferred start " Oleksandr Kolomeiets
2025-06-20 11:27 ` [PATCH v1 1/4] net/ntnic: implement start/stop " Oleksandr Kolomeiets
2025-06-29 17:50 ` Stephen Hemminger [this message]
2025-06-20 11:27 ` [PATCH v1 2/4] net/ntnic: implement deferred start " Oleksandr Kolomeiets
2025-06-20 11:27 ` [PATCH v1 3/4] net/ntnic: unmap DMA during queue release Oleksandr Kolomeiets
2025-06-20 11:27 ` [PATCH v1 4/4] net/ntnic: add warning when sending on a stopped queue Oleksandr Kolomeiets
2025-06-29 17:53 ` Stephen Hemminger
2025-06-28 22:20 ` [PATCH v1 0/4] net/ntnic: implement start, stop and deferred start for Rx/Tx queues Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250629105042.00929828@hermes.local \
--to=stephen@networkplumber.org \
--cc=ckm@napatech.com \
--cc=dev@dpdk.org \
--cc=mko-plv@napatech.com \
--cc=okl-plv@napatech.com \
--cc=sil-plv@napatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).