DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bingbin Chen <chen.bingbin@zte.com.cn>
Cc: wang.junlong1@zte.com.cn, yang.yonggang@zte.com.cn, dev@dpdk.org
Subject: Re: [PATCH v2 2/2] net/zxdh: add support flow director ops
Date: Mon, 30 Jun 2025 09:56:26 -0700	[thread overview]
Message-ID: <20250630095626.679e0999@hermes.local> (raw)
In-Reply-To: <20250618074936.3616999-3-chen.bingbin@zte.com.cn>

On Wed, 18 Jun 2025 15:49:30 +0800
Bingbin Chen <chen.bingbin@zte.com.cn> wrote:

> Provide support for ETH, VLAN, IPv4/IPv6, TCP/UDP, VXLAN, and mask matching,
> supporting multiple actions include drop/count/mark/queue/rss,and vxlan decap/encap.
> 
> Signed-off-by: Bingbin Chen <chen.bingbin@zte.com.cn>
> ---

There are several checkpatch warnings in this file.
These are the ones that should be fixed (ignore complaints about stdio and macro arg reuse, etc).

Please fix and resubmit the patch set for 25.07


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#60: 
Provide support for ETH, VLAN, IPv4/IPv6, TCP/UDP, VXLAN, and mask matching,

WARNING:TYPO_SPELLING: 'realease' may be misspelled - perhaps 'release'?
#1235: FILE: drivers/net/zxdh/zxdh_flow.c:904:
+						 "realease handle_idx to hw failed");

WARNING:TYPO_SPELLING: 'realease' may be misspelled - perhaps 'release'?
#1426: FILE: drivers/net/zxdh/zxdh_flow.c:1095:
+						"realease handle_idx to hw failed");

WARNING:TYPO_SPELLING: 'realease' may be misspelled - perhaps 'release'?
#1429: FILE: drivers/net/zxdh/zxdh_flow.c:1098:
+	PMD_DRV_LOG(DEBUG, "realease handle_idx to hw succ! %d", handle_idx);

ERROR:C99_COMMENTS: do not use C99 // comments
#1620: FILE: drivers/net/zxdh/zxdh_flow.c:1289:
+				//ether_type = rte_be_to_cpu_16(eth_spec->type);

      reply	other threads:[~2025-06-30 16:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17  9:31 [PATCH v1 0/2] " Bingbin Chen
2025-06-17  9:32 ` [PATCH v1 1/2] net/zxdh: npsdk add flow director table ops Bingbin Chen
2025-06-17 14:07   ` Stephen Hemminger
2025-06-17 14:08   ` Stephen Hemminger
2025-06-17  9:32 ` [PATCH v1 2/2] net/zxdh: add support flow director ops Bingbin Chen
2025-06-18  7:49 ` [PATCH v2 0/2] " Bingbin Chen
2025-06-18  7:49   ` [PATCH v2 1/2] net/zxdh: npsdk add flow director table ops Bingbin Chen
2025-06-18  7:49   ` [PATCH v2 2/2] net/zxdh: add support flow director ops Bingbin Chen
2025-06-30 16:56     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250630095626.679e0999@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=chen.bingbin@zte.com.cn \
    --cc=dev@dpdk.org \
    --cc=wang.junlong1@zte.com.cn \
    --cc=yang.yonggang@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).