DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] node: fix C++ compatibility errors (option 2)
Date: Mon, 30 Jun 2025 11:50:14 +0100	[thread overview]
Message-ID: <20250630105025.2265901-1-bruce.richardson@intel.com> (raw)

C++ does not allow zero-sized unions - they end up being of size 1-byte,
which leads to C/C++ compatibility issues, flagged by the compiler.

  lib/node/rte_node_mbuf_dynfield.h:78:2: error: union has size 0 in C,
size 1 in C++ [-Werror,-Wextern-c-compat]
   78 |         union {
	         |         ^
		 1 error generated.

Fix the error by omitting the persistent_data field when it is
zero-sized, since it's unusable. Any app using the field must already
specify a size for the persistent data.

Fixes: 746e8736da70 ("node: add global mbuf dynfield")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/node/rte_node_mbuf_dynfield.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/node/rte_node_mbuf_dynfield.h b/lib/node/rte_node_mbuf_dynfield.h
index b77fdbb94f..09254c585a 100644
--- a/lib/node/rte_node_mbuf_dynfield.h
+++ b/lib/node/rte_node_mbuf_dynfield.h
@@ -69,6 +69,7 @@ typedef struct rte_node_mbuf_overload_fields {
  * 2. Overloadable fields: Fields which can be repurposed by two adjacent nodes.
  */
 typedef struct rte_node_mbuf_dynfield {
+#if RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE > 0
 	/**
 	 * Persistent mbuf region across nodes in graph walk
 	 *
@@ -78,6 +79,7 @@ typedef struct rte_node_mbuf_dynfield {
 	union {
 		uint8_t persistent_data[RTE_NODE_MBUF_PERSISTENT_FIELDS_SIZE];
 	};
+#endif
 	/**
 	 * Overloadable mbuf fields across graph walk. Fields which can change.
 	 *
-- 
2.48.1


             reply	other threads:[~2025-06-30 10:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 10:50 Bruce Richardson [this message]
2025-07-01 13:04 ` Thomas Monjalon
2025-07-01 14:48 ` Nitin Saxena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250630105025.2265901-1-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).