From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: dev@dpdk.org, zaiyuwang@trustnetic.com
Subject: Re: [PATCH v3 01/17] net/txgbe: support flow filter for VF
Date: Tue, 1 Jul 2025 07:38:58 -0700 [thread overview]
Message-ID: <20250701073858.161dce1c@hermes.local> (raw)
In-Reply-To: <20250613084159.22184-2-jiawenwu@trustnetic.com>
On Fri, 13 Jun 2025 16:41:43 +0800
Jiawen Wu <jiawenwu@trustnetic.com> wrote:
> +bool txgbe_is_pf(struct txgbe_hw *hw)
> +{
> + switch (hw->mac.type) {
> + case txgbe_mac_raptor:
> + return true;
> + default:
> + return false;
> + }
> +}
> +
This is ok as is, but you could make it much simpler as:
bool txgbe_is_pf(const struct txgbe_hw *hw)
{
return hw->mac.type == txgbe_mac_raptor;
}
Or are you planning for future hardware?
next prev parent reply other threads:[~2025-07-01 14:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 8:01 [PATCH 00/12] Fixes and supports for Wangxun NICs Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 " Jiawen Wu
[not found] ` <20250609070454.223387-1-jiawenwu@trustnetic.com>
2025-06-09 7:04 ` [PATCH v2 01/12] net/txgbe: support flow filter for VF Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 02/12] net/txgbe: refactor FDIR filter to improve functionality Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 03/12] net/txgbe: fix reserved extra FDIR headroom Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 04/12] net/txgbe: support RSS offload for SCTP port Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 05/12] net/ngbe: " Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 06/12] net/txgbe: fix MAC control frame forwarding Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 07/12] net/ngbe: " Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 08/12] net/txgbe: fix incorrect device statistics Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 09/12] net/ngbe: " Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 10/12] net/txgbe: restrict VLAN strip configuration on VF Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 11/12] net/ngbe: " Jiawen Wu
2025-06-09 7:04 ` [PATCH v2 12/12] net/txgbe: add missing LRO flag in mbuf when LRO enabled Jiawen Wu
2025-06-10 23:38 ` [PATCH 00/12] Fixes and supports for Wangxun NICs Stephen Hemminger
2025-06-11 2:00 ` Stephen Hemminger
2025-06-13 8:41 ` [PATCH v3 00/17] " Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 01/17] net/txgbe: support flow filter for VF Jiawen Wu
2025-07-01 14:38 ` Stephen Hemminger [this message]
2025-07-02 1:41 ` Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 02/17] net/txgbe: fix incorrect parsing to ntuple filter Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 03/17] net/txgbe: fix raw pattern match for FDIR rules Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 04/17] net/txgbe: fix packet type for FDIR filters Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 05/17] net/txgbe: fix to create FDIR filters for SCTP packets Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 06/17] net/txgbe: fix FDIR perfect mode for IPv6 packets Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 07/17] net/txgbe: fix to create FDIR filters for tunnel packets Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 08/17] net/txgbe: fix reserved extra FDIR headroom Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 09/17] net/txgbe: support RSS offload for SCTP port Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 10/17] net/ngbe: " Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 11/17] net/txgbe: fix MAC control frame forwarding Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 12/17] net/ngbe: " Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 13/17] net/txgbe: fix incorrect device statistics Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 14/17] net/ngbe: " Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 15/17] net/txgbe: restrict VLAN strip configuration on VF Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 16/17] net/ngbe: " Jiawen Wu
2025-06-13 8:41 ` [PATCH v3 17/17] net/txgbe: add missing LRO flag in mbuf when LRO enabled Jiawen Wu
2025-06-17 15:22 ` [PATCH v3 00/17] Fixes and supports for Wangxun NICs Stephen Hemminger
2025-07-01 15:13 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701073858.161dce1c@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).