From: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
To: dev@dpdk.org
Cc: amiyaranjan.mohakud@gmail.com, stable@dpdk.org
Subject: [PATCH v3] net/iavf: fix VLAN offload strip flag
Date: Thu, 3 Jul 2025 00:08:56 +0530 [thread overview]
Message-ID: <20250702183856.99326-1-amiyaranjan.mohakud@gmail.com> (raw)
In-Reply-To: <20250702182251.96427-1-amiyaranjan.mohakud@gmail.com>
For i40e kernel drivers which support either vlan(v1) or vlan(v2)
VIRTCHNL OP,it will set strip on when setting filter on. But dpdk
side will not change strip flag. To be consistent with dpdk side,
explicitly disable strip again.
Bugzilla ID:1725
Cc: stable@dpdk.org
v3:
- Fixed the vlan(v2) scenario by calling appropriate api
- Addresses Bugzilla ID: 1735
v2:
- Fixed indentation in commit message
Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
---
drivers/net/intel/iavf/iavf_ethdev.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
index c33fdd9069..335a8126c4 100644
--- a/drivers/net/intel/iavf/iavf_ethdev.c
+++ b/drivers/net/intel/iavf/iavf_ethdev.c
@@ -1388,6 +1388,7 @@ iavf_disable_vlan_strip_ex(struct rte_eth_dev *dev, int on)
*/
struct iavf_adapter *adapter =
IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+ struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);
struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
int err;
@@ -1395,7 +1396,10 @@ iavf_disable_vlan_strip_ex(struct rte_eth_dev *dev, int on)
adapter->hw.mac.type == IAVF_MAC_VF ||
adapter->hw.mac.type == IAVF_MAC_X722_VF) {
if (on && !(dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) {
- err = iavf_disable_vlan_strip(adapter);
+ if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN_V2)
+ err = iavf_config_vlan_strip_v2(adapter, false);
+ else
+ err = iavf_disable_vlan_strip(adapter);
if (err)
return -EIO;
}
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-07-02 18:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 1:56 [PATCH] " Amiya Ranjan Mohakud
2025-06-23 10:57 ` Loftus, Ciara
2025-06-23 18:11 ` [PATCH v2] " Amiya Ranjan Mohakud
2025-06-23 18:50 ` Amiya Ranjan Mohakud
2025-06-24 9:19 ` Loftus, Ciara
2025-06-24 15:29 ` Amiya Ranjan Mohakud
2025-06-25 14:01 ` Loftus, Ciara
2025-06-25 16:00 ` Bruce Richardson
2025-06-26 3:34 ` Amiya Ranjan Mohakud
2025-06-26 4:34 ` Amiya Ranjan Mohakud
2025-06-24 9:19 ` Loftus, Ciara
2025-07-02 18:15 ` [PATCH] " Amiya Ranjan Mohakud
2025-07-02 18:22 ` [PATCH v3] " Amiya Ranjan Mohakud
2025-07-02 18:38 ` Amiya Ranjan Mohakud [this message]
2025-07-03 8:17 ` Loftus, Ciara
2025-07-03 8:25 ` Amiya Ranjan Mohakud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702183856.99326-1-amiyaranjan.mohakud@gmail.com \
--to=amiyaranjan.mohakud@gmail.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).