From: madhuker.mythri@oracle.com
To: chas3@att.com
Cc: dev@dpdk.org, Madhuker Mythri <madhuker.mythri@oracle.com>
Subject: [PATCH] net/bonding: avoid RSS reta update in flow-isolation mode
Date: Thu, 3 Jul 2025 17:29:03 +0530 [thread overview]
Message-ID: <20250703115903.7157-1-madhuker.mythri@oracle.com> (raw)
From: Madhuker Mythri <madhuker.mythri@oracle.com>
In bonding PMD, member_start() function checks whether RSS(mq_mode) is
enabled and then calling the RSS rte_eth_dev_rss_reta_update() API, which
is returning error in-case of device configured in flow isolation-mode.
When the device configured with flow isolation mode RSS reta update is not
required and the API was not supported. For example in-case of mlx5 PMD,
RSS reta update API was not supported, when the device is configured in
flow isolation-mode.
So, added check to verify if the device is configured in flow-isolation
mode, then do not call the rte_eth_dev_rss_reta_update() API.
Signed-off-by: Madhuker Mythri <madhuker.mythri@oracle.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 83339bae3d..b8fecb85d2 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1904,12 +1904,11 @@ member_start(struct rte_eth_dev *bonding_eth_dev,
}
}
- /* If RSS is enabled for bonding, synchronize RETA */
- if (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
+ /* If flow-isolation is not enabled, then check whether RSS is enabled for
+ * bonding, synchronize RETA */
+ if (internals->flow_isolated_valid == 0 &&
+ (bonding_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS)) {
int i;
- struct bond_dev_private *internals;
-
- internals = bonding_eth_dev->data->dev_private;
for (i = 0; i < internals->member_count; i++) {
if (internals->members[i].port_id == member_port_id) {
--
2.39.5 (Apple Git-154)
next reply other threads:[~2025-07-03 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 11:59 madhuker.mythri [this message]
2025-07-03 16:23 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2025-07-03 11:37 madhuker.mythri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703115903.7157-1-madhuker.mythri@oracle.com \
--to=madhuker.mythri@oracle.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).