From: Luca Vizzarro <luca.vizzarro@arm.com>
To: dev@dpdk.org
Cc: Luca Vizzarro <luca.vizzarro@arm.com>,
Patrick Robb <probb@iol.unh.edu>,
Paul Szczepanek <paul.szczepanek@arm.com>
Subject: [PATCH v2 1/2] dts: remove dpdk example build function
Date: Fri, 4 Jul 2025 16:29:07 +0100 [thread overview]
Message-ID: <20250704152908.683265-2-luca.vizzarro@arm.com> (raw)
In-Reply-To: <20250704152908.683265-1-luca.vizzarro@arm.com>
Usage of example DPDK apps should be avoided. Therefore, remove
the function that allows to build example apps. Moreover,
provide a dedicated helper function to retrieve the path to a
DPDK app.
Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
---
dts/framework/remote_session/dpdk.py | 33 +++-------------------------
1 file changed, 3 insertions(+), 30 deletions(-)
diff --git a/dts/framework/remote_session/dpdk.py b/dts/framework/remote_session/dpdk.py
index e00c4a9bf9..606d6e22fe 100644
--- a/dts/framework/remote_session/dpdk.py
+++ b/dts/framework/remote_session/dpdk.py
@@ -267,36 +267,9 @@ def _build_dpdk(self) -> None:
self.remote_dpdk_build_dir,
)
- def build_dpdk_app(self, app_name: str, **meson_dpdk_args: str | bool) -> PurePath:
- """Build one or all DPDK apps.
-
- Requires DPDK to be already built on the SUT node.
-
- Args:
- app_name: The name of the DPDK app to build.
- When `app_name` is ``all``, build all example apps.
- meson_dpdk_args: The arguments found in ``meson_options.txt`` in root DPDK directory.
- Do not use ``-D`` with them.
-
- Returns:
- The directory path of the built app. If building all apps, return
- the path to the examples directory (where all apps reside).
- """
- self._session.build_dpdk(
- self._env_vars,
- MesonArgs(examples=app_name, **meson_dpdk_args), # type: ignore [arg-type]
- # ^^ https://github.com/python/mypy/issues/11583
- self.remote_dpdk_tree_path,
- self.remote_dpdk_build_dir,
- rebuild=True,
- timeout=self._app_compile_timeout,
- )
-
- if app_name == "all":
- return self._session.join_remote_path(self.remote_dpdk_build_dir, "examples")
- return self._session.join_remote_path(
- self.remote_dpdk_build_dir, "examples", f"dpdk-{app_name}"
- )
+ def get_app(self, app_name: str) -> PurePath:
+ """Retrieve path for a DPDK app."""
+ return self._session.join_remote_path(self.remote_dpdk_build_dir, "app", f"dpdk-{app_name}")
@cached_property
def remote_dpdk_tree_path(self) -> PurePath:
--
2.43.0
next prev parent reply other threads:[~2025-07-04 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 16:42 [PATCH 0/2] dts: add generic blocking app class Luca Vizzarro
2025-07-02 16:42 ` [PATCH 1/2] dts: add DPDK build app helper function Luca Vizzarro
2025-07-03 15:35 ` Dean Marx
2025-07-04 3:04 ` Patrick Robb
2025-07-02 16:42 ` [PATCH 2/2] dts: add generic blocking app class Luca Vizzarro
2025-07-03 15:35 ` Dean Marx
2025-07-04 3:23 ` Patrick Robb
2025-07-04 15:29 ` [PATCH v2 0/2] " Luca Vizzarro
2025-07-04 15:29 ` Luca Vizzarro [this message]
2025-07-04 16:36 ` [PATCH v2 1/2] dts: remove dpdk example build function Patrick Robb
2025-07-04 15:29 ` [PATCH v2 2/2] dts: add generic blocking app class Luca Vizzarro
2025-07-04 16:36 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704152908.683265-2-luca.vizzarro@arm.com \
--to=luca.vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).