* [PATCH] net/ice: fix Rx vector offload flags
@ 2025-08-07 11:08 Bruce Richardson
2025-08-07 12:42 ` Loftus, Ciara
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2025-08-07 11:08 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
The vector PMD datapaths for ice do not support QinQ, so we need to
update the vector offload flags to not use the general RX_OFFLOAD_VLAN
flag (which sets all vlan-related options) and replace it with the
individually supported VLAN options.
Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/intel/ice/ice_rxtx_vec_common.h b/drivers/net/intel/ice/ice_rxtx_vec_common.h
index 9430a99ba5..e41fd8fc7c 100644
--- a/drivers/net/intel/ice/ice_rxtx_vec_common.h
+++ b/drivers/net/intel/ice/ice_rxtx_vec_common.h
@@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue *rxq)
#define ICE_RX_VECTOR_OFFLOAD ( \
RTE_ETH_RX_OFFLOAD_CHECKSUM | \
RTE_ETH_RX_OFFLOAD_SCTP_CKSUM | \
- RTE_ETH_RX_OFFLOAD_VLAN | \
+ RTE_ETH_RX_OFFLOAD_VLAN_STRIP | \
+ RTE_ETH_RX_OFFLOAD_VLAN_FILTER | \
RTE_ETH_RX_OFFLOAD_RSS_HASH)
#define ICE_VECTOR_PATH 0
--
2.48.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/ice: fix Rx vector offload flags
2025-08-07 11:08 [PATCH] net/ice: fix Rx vector offload flags Bruce Richardson
@ 2025-08-07 12:42 ` Loftus, Ciara
2025-08-07 14:13 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Loftus, Ciara @ 2025-08-07 12:42 UTC (permalink / raw)
To: Richardson, Bruce, dev; +Cc: Richardson, Bruce, stable
>
> The vector PMD datapaths for ice do not support QinQ, so we need to
> update the vector offload flags to not use the general RX_OFFLOAD_VLAN
> flag (which sets all vlan-related options) and replace it with the
> individually supported VLAN options.
>
> Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> index 9430a99ba5..e41fd8fc7c 100644
> --- a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> +++ b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> @@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue
> *rxq)
> #define ICE_RX_VECTOR_OFFLOAD ( \
> RTE_ETH_RX_OFFLOAD_CHECKSUM | \
> RTE_ETH_RX_OFFLOAD_SCTP_CKSUM | \
> - RTE_ETH_RX_OFFLOAD_VLAN | \
> + RTE_ETH_RX_OFFLOAD_VLAN_STRIP | \
> + RTE_ETH_RX_OFFLOAD_VLAN_FILTER | \
> RTE_ETH_RX_OFFLOAD_RSS_HASH)
>
> #define ICE_VECTOR_PATH 0
> --
> 2.48.1
LGTM.
Acked-by: Ciara Loftus <ciara.loftus@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ice: fix Rx vector offload flags
2025-08-07 12:42 ` Loftus, Ciara
@ 2025-08-07 14:13 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2025-08-07 14:13 UTC (permalink / raw)
To: Loftus, Ciara; +Cc: dev, stable
On Thu, Aug 07, 2025 at 01:42:54PM +0100, Loftus, Ciara wrote:
> >
> > The vector PMD datapaths for ice do not support QinQ, so we need to
> > update the vector offload flags to not use the general RX_OFFLOAD_VLAN
> > flag (which sets all vlan-related options) and replace it with the
> > individually supported VLAN options.
> >
> > Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> > b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> > index 9430a99ba5..e41fd8fc7c 100644
> > --- a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> > +++ b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> > @@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue
> > *rxq)
> > #define ICE_RX_VECTOR_OFFLOAD ( \
> > RTE_ETH_RX_OFFLOAD_CHECKSUM | \
> > RTE_ETH_RX_OFFLOAD_SCTP_CKSUM | \
> > - RTE_ETH_RX_OFFLOAD_VLAN | \
> > + RTE_ETH_RX_OFFLOAD_VLAN_STRIP | \
> > + RTE_ETH_RX_OFFLOAD_VLAN_FILTER | \
> > RTE_ETH_RX_OFFLOAD_RSS_HASH)
> >
> > #define ICE_VECTOR_PATH 0
> > --
> > 2.48.1
>
> LGTM.
>
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
>
Applied to dpdk-next-net-intel.
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-07 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-07 11:08 [PATCH] net/ice: fix Rx vector offload flags Bruce Richardson
2025-08-07 12:42 ` Loftus, Ciara
2025-08-07 14:13 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).