From: Stephen Hemminger <stephen@networkplumber.org>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer
Date: Fri, 8 Aug 2025 08:32:04 -0700 [thread overview]
Message-ID: <20250808083204.0174ac6b@hermes.local> (raw)
In-Reply-To: <PH7PR12MB8596FA05DD99084208A31E50822FA@PH7PR12MB8596.namprd12.prod.outlook.com>
On Fri, 8 Aug 2025 03:49:01 +0000
"Varghese, Vipin" <Vipin.Varghese@amd.com> wrote:
> [Public]
>
> Since somehow the email are split it is difficult to see the indexing
>
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Hi Stephen,
> >
> > Many thanks for diving deeper into the issue and sharing the insights.
> >
> > I agree. given that the primary tears down all the devices on exit, the secondary is
> > left with dangling pointers and inconsistent state.
>
> Secondary if PMD should not be attempting to cleanup (especially for ethdev_ptr shared from primary) I agree to that.
> But should not be covered in library or PMD. While cleanup for other needs to be done properly
>
> Without a mechanism to notify or synchronize that teardown,
>
> You already have health check added in the code for identify if primay is still alive or not..
> There used to be MP thread spawned which actually piggy back the communication. Is this broken? Can you please point to git
There is no easy way to handle the case where primary crashes; leaving secondary process with
pointers to dead data.
next prev parent reply other threads:[~2025-08-08 15:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 11:54 [PATCH] " Khadem Ullah
2025-07-22 13:39 ` Stephen Hemminger
2025-07-22 14:30 ` Khadem Ullah
2025-07-22 15:42 ` Stephen Hemminger
2025-07-22 16:01 ` Khadem Ullah
2025-07-22 16:13 ` Bruce Richardson
2025-07-22 17:04 ` Khadem Ullah
2025-07-22 17:38 ` Stephen Hemminger
2025-07-22 17:53 ` Khadem Ullah
2025-07-22 18:21 ` Stephen Hemminger
2025-07-22 19:03 ` Khadem Ullah
2025-07-22 19:05 ` Ivan Malov
2025-07-22 22:28 ` Stephen Hemminger
2025-07-23 4:29 ` Khadem Ullah
2025-07-23 4:50 ` [PATCH v2] " Khadem Ullah
2025-07-23 12:19 ` Khadem Ullah
2025-07-23 13:13 ` Khadem Ullah
2025-07-23 13:24 ` Ivan Malov
2025-07-23 13:26 ` Khadem Ullah
2025-07-23 13:31 ` Ivan Malov
2025-07-23 13:10 ` [PATCH] [PATCH v3] " Khadem Ullah
2025-07-23 13:19 ` Ivan Malov
2025-07-23 13:34 ` Khadem Ullah
2025-07-23 14:22 ` Stephen Hemminger
2025-07-24 5:49 ` Khadem Ullah
2025-07-25 13:00 ` Khadem Ullah
2025-07-25 12:55 ` [PATCH] [PATCH v4] " Khadem Ullah
2025-07-28 21:45 ` Stephen Hemminger
2025-07-29 5:42 ` Khadem Ullah
2025-07-29 21:34 ` Stephen Hemminger
2025-07-30 5:07 ` Khadem Ullah
2025-08-08 3:49 ` Varghese, Vipin
2025-08-08 15:32 ` Stephen Hemminger [this message]
2025-07-29 6:39 ` [PATCH] app/testpmd: fix segfault in secondary process by monitoring primary Khadem Ullah
2025-07-29 6:39 ` [PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Khadem Ullah
2025-07-29 6:39 ` [PATCH] [PATCH v5] app/testpmd: fix segfault in secondary process by monitoring primary Khadem Ullah
2025-07-29 14:48 ` Stephen Hemminger
2025-07-29 21:48 ` Stephen Hemminger
2025-07-30 5:24 ` Khadem Ullah
2025-08-08 3:44 ` Varghese, Vipin
2025-08-08 16:17 ` Stephen Hemminger
2025-07-30 5:56 ` [PATCH] app/testpmd: monitor state of primary process when using secondary Khadem Ullah
2025-07-30 6:08 ` [PATCH v6] " Khadem Ullah
2025-08-01 22:50 ` Stephen Hemminger
2025-08-04 7:54 ` [PATCH v7] " Khadem Ullah
2025-08-04 11:33 ` Khadem Ullah
2025-08-04 15:44 ` Stephen Hemminger
2025-08-05 0:50 ` fengchengwen
2025-08-08 3:23 ` Varghese, Vipin
2025-08-08 5:44 ` Khadem Ullah
2025-08-08 10:59 ` Varghese, Vipin
2025-08-08 11:49 ` Khadem Ullah
2025-08-08 16:49 ` Stephen Hemminger
2025-08-08 17:01 ` Khadem Ullah
2025-08-08 15:28 ` Stephen Hemminger
2025-08-08 15:50 ` Khadem Ullah
2025-08-08 16:10 ` Stephen Hemminger
2025-07-23 14:21 ` [PATCH v2] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808083204.0174ac6b@hermes.local \
--to=stephen@networkplumber.org \
--cc=14pwcse1224@uetpeshawar.edu.pk \
--cc=Ferruh.Yigit@amd.com \
--cc=Vipin.Varghese@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).