From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Tal Shnaiderman <talshn@nvidia.com>
Subject: Re: [PATCH 2/3] net/mlx5: fix build with MinGW 13
Date: Thu, 14 Aug 2025 11:50:57 +0200 [thread overview]
Message-ID: <20250814095057.pe3dpojxsmg2l64n@ds-vm-debian.local> (raw)
In-Reply-To: <20250813152829.457463-3-thomas@monjalon.net>
On Wed, Aug 13, 2025 at 05:25:24PM +0200, Thomas Monjalon wrote:
> After an upgrade to MinGW version 13, compilation breaks:
>
> drivers/net/mlx5/windows/mlx5_ethdev_os.c:285:69: error:
> 'dev_link.<U1000>.<Uaf00>.link_autoneg' may be used uninitialized
>
> This is because link_autoneg is never set in mlx5_link_update().
> It can be set to the previous value (no change).
> Also it does not make sense to check this value to return the update status
> as it does not change.
>
> Fixes: 6fbd73709ee4 ("net/mlx5: support link update on Windows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2025-08-14 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 15:25 [PATCH 0/3] " Thomas Monjalon
2025-08-13 15:25 ` [PATCH 1/3] bus/pci: " Thomas Monjalon
2025-08-13 15:25 ` [PATCH 2/3] net/mlx5: " Thomas Monjalon
2025-08-14 9:50 ` Dariusz Sosnowski [this message]
2025-08-13 15:25 ` [PATCH 3/3] bbdev: wrong fix for " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814095057.pe3dpojxsmg2l64n@ds-vm-debian.local \
--to=dsosnowski@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).