From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Reshma Pattan <reshma.pattan@intel.com>
Subject: [PATCH v2 7/8] pdump: remove use of VLA
Date: Thu, 14 Aug 2025 09:53:03 -0700 [thread overview]
Message-ID: <20250814165307.12786-8-stephen@networkplumber.org> (raw)
In-Reply-To: <20250814165307.12786-1-stephen@networkplumber.org>
Replace variable length array with alloca.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/pdump/meson.build | 2 --
lib/pdump/rte_pdump.c | 12 ++++++++----
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/pdump/meson.build b/lib/pdump/meson.build
index 553dfdd5e6..da8d51b616 100644
--- a/lib/pdump/meson.build
+++ b/lib/pdump/meson.build
@@ -7,8 +7,6 @@ if is_windows
subdir_done()
endif
-cflags += no_wvla_cflag
-
sources = files('rte_pdump.c')
headers = files('rte_pdump.h')
deps += ['ethdev', 'bpf', 'pcapng']
diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index b95f7f863d..d201997b75 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -144,17 +144,21 @@ pdump_copy(uint16_t port_id, uint16_t queue,
unsigned int i;
int ring_enq;
uint16_t d_pkts = 0;
- struct rte_mbuf *dup_bufs[nb_pkts];
+ struct rte_mbuf **dup_bufs;
struct rte_ring *ring;
struct rte_mempool *mp;
struct rte_mbuf *p;
- uint64_t rcs[nb_pkts];
+ uint64_t *rcs = NULL;
- if (cbs->filter)
+ if (cbs->filter) {
+ rcs = alloca(sizeof(uint64_t) * nb_pkts);
rte_bpf_exec_burst(cbs->filter, (void **)pkts, rcs, nb_pkts);
+ }
ring = cbs->ring;
mp = cbs->mp;
+ dup_bufs = alloca(sizeof(struct rte_mbuf *) * nb_pkts);
+
for (i = 0; i < nb_pkts; i++) {
/*
* This uses same BPF return value convention as socket filter
@@ -162,7 +166,7 @@ pdump_copy(uint16_t port_id, uint16_t queue,
* if program returns zero
* then packet doesn't match the filter (will be ignored).
*/
- if (cbs->filter && rcs[i] == 0) {
+ if (rcs != NULL && rcs[i] == 0) {
rte_atomic_fetch_add_explicit(&stats->filtered,
1, rte_memory_order_relaxed);
continue;
--
2.47.2
next prev parent reply other threads:[~2025-08-14 16:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 21:34 [RFC 0/6] Packet capture fixes Stephen Hemminger
2025-08-11 21:34 ` [RFC 1/6] dumpcap: handle primary process exit Stephen Hemminger
2025-08-11 21:35 ` [RFC 2/6] pdump: " Stephen Hemminger
2025-08-11 21:35 ` [RFC 3/6] pdump: fix races in callbacks Stephen Hemminger
2025-08-11 21:35 ` [RFC 4/6] dumpcap: handle pdump requests from primary Stephen Hemminger
2025-08-11 21:35 ` [RFC 5/6] pdump: " Stephen Hemminger
2025-08-11 21:35 ` [RFC 6/6] pdump: forward callback enable to secondary Stephen Hemminger
2025-08-14 16:52 ` [PATCH v2 0/8] Packet capture cleanup Stephen Hemminger
2025-08-14 16:52 ` [PATCH v2 1/8] dumpcap: handle primary process exit Stephen Hemminger
2025-08-14 16:52 ` [PATCH v2 2/8] pdump: " Stephen Hemminger
2025-08-14 16:52 ` [PATCH v2 3/8] pdump: fix races in callbacks Stephen Hemminger
2025-08-14 16:53 ` [PATCH v2 4/8] dumpcap: handle pdump requests from primary Stephen Hemminger
2025-08-14 16:53 ` [PATCH v2 5/8] pdump: " Stephen Hemminger
2025-08-14 16:53 ` [PATCH v2 6/8] pdump: forward callback enable to secondary Stephen Hemminger
2025-08-14 16:53 ` Stephen Hemminger [this message]
2025-08-14 16:53 ` [PATCH v2 8/8] doc: update documentation on pdump library Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814165307.12786-8-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).