From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>
Subject: [PATCH v2 5/6] app/testpmd: replace comma operator with bracket
Date: Thu, 14 Aug 2025 14:28:51 -0700 [thread overview]
Message-ID: <20250814212901.88863-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20250814212901.88863-1-stephen@networkplumber.org>
Use while with brackets in favor of comma operator.
In flow print replace with temporary variable.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test-pmd/cmdline_flow.c | 6 ++++--
app/test-pmd/config.c | 10 ++++++----
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 83d398f8ee..a54463f718 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -8333,8 +8333,10 @@ parse_prefix(struct context *ctx, const struct token *token,
if (!ctx->object)
return len;
extra -= u;
- while (u--)
- (v <<= 1, v |= 1);
+ while (u--) {
+ v <<= 1;
+ v |= 1;
+ }
v <<= extra;
if (!arg_entry_bf_fill(ctx->object, v, arg) ||
!arg_entry_bf_fill(ctx->objmask, -1, arg))
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 0fda8e99f8..14af69bce5 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1497,7 +1497,7 @@ port_flow_complain(struct rte_flow_error *error)
[RTE_FLOW_ERROR_TYPE_ACTION] = "specific action",
};
const char *errstr;
- char buf[32];
+ char cause_buf[32] = "";
int err = rte_errno;
if ((unsigned int)error->type >= RTE_DIM(errstrlist) ||
@@ -1505,10 +1505,12 @@ port_flow_complain(struct rte_flow_error *error)
errstr = "unknown type";
else
errstr = errstrlist[error->type];
+
+ if (error->cause)
+ snprintf(cause_buf, sizeof(cause_buf), "cause: %p, ", error->cause);
+
fprintf(stderr, "%s(): Caught PMD error type %d (%s): %s%s: %s\n",
- __func__, error->type, errstr,
- error->cause ? (snprintf(buf, sizeof(buf), "cause: %p, ",
- error->cause), buf) : "",
+ __func__, error->type, errstr, cause_buf,
error->message ? error->message : "(no stated reason)",
rte_strerror(err));
--
2.47.2
next prev parent reply other threads:[~2025-08-14 21:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-14 21:28 ` Stephen Hemminger [this message]
2025-08-14 21:28 ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 0:30 ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814212901.88863-6-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).