From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v2 6/6] config: enable comma warnings
Date: Thu, 14 Aug 2025 14:28:52 -0700 [thread overview]
Message-ID: <20250814212901.88863-7-stephen@networkplumber.org> (raw)
In-Reply-To: <20250814212901.88863-1-stephen@networkplumber.org>
Clang (3.9 or later) has a -Wcomma that emits warnings for questionable
uses of the comma operator.
Don't enable it for drivers since many drivers still use
comma operator unnecessarily.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
config/meson.build | 1 +
drivers/meson.build | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/config/meson.build b/config/meson.build
index f31fef216c..d9ff0e31c0 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -313,6 +313,7 @@ endif
global_cflags = [
# additional warnings in alphabetical order
'-Wcast-qual',
+ '-Wcomma',
'-Wdeprecated',
'-Wformat',
'-Wformat-nonliteral',
diff --git a/drivers/meson.build b/drivers/meson.build
index b62880db02..4c08a1dd9d 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -59,7 +59,7 @@ default_cflags = machine_args
default_cflags += ['-DALLOW_EXPERIMENTAL_API']
default_cflags += ['-DALLOW_INTERNAL_API']
-warning_disable_cflags = ['-Wno-format-truncation', '-Wno-address-of-packed-member']
+warning_disable_cflags = ['-Wno-format-truncation', '-Wno-address-of-packed-member', '-Wno-comma']
foreach cflag:warning_disable_cflags
if cc.has_argument(cflag)
default_cflags += cflag
--
2.47.2
next prev parent reply other threads:[~2025-08-14 21:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` Stephen Hemminger [this message]
2025-08-15 0:30 ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814212901.88863-7-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).