DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/idpf: correct the enum constant name typo
@ 2025-10-07  4:04 Shaiq Wani
  2025-10-07 12:46 ` Burakov, Anatoly
  2025-10-08  8:28 ` Bruce Richardson
  0 siblings, 2 replies; 3+ messages in thread
From: Shaiq Wani @ 2025-10-07  4:04 UTC (permalink / raw)
  To: dev, bruce.richardson, aman.deep.singh

Correct the typo in the idpf_rx_func_type enum by renaming
IDPF_RX_SINGLQ_AVX512 to IDPF_RX_SINGLEQ_AVX512 for consistency
and improved readability.

Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
 drivers/net/intel/idpf/idpf_common_device.h | 2 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/intel/idpf/idpf_common_device.h b/drivers/net/intel/idpf/idpf_common_device.h
index 3b95d519c6..09d59dd0c1 100644
--- a/drivers/net/intel/idpf/idpf_common_device.h
+++ b/drivers/net/intel/idpf/idpf_common_device.h
@@ -50,7 +50,7 @@ enum idpf_rx_func_type {
 	IDPF_RX_SINGLEQ_SCATTERED,
 	IDPF_RX_SINGLEQ_AVX2,
 	IDPF_RX_AVX512,
-	IDPF_RX_SINGLQ_AVX512,
+	IDPF_RX_SINGLEQ_AVX512,
 	IDPF_RX_MAX
 };
 
diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c b/drivers/net/intel/idpf/idpf_common_rxtx.c
index a2b8c372d6..5a1c1561e5 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx.c
@@ -1663,7 +1663,7 @@ const struct ci_rx_path_info idpf_rx_path_infos[] = {
 		.features = {
 			.rx_offloads = IDPF_RX_VECTOR_OFFLOADS,
 			.simd_width = RTE_VECT_SIMD_512}},
-	[IDPF_RX_SINGLQ_AVX512] = {
+	[IDPF_RX_SINGLEQ_AVX512] = {
 		.pkt_burst = idpf_dp_singleq_recv_pkts_avx512,
 		.info = "Single AVX512 Vector",
 		.features = {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/idpf: correct the enum constant name typo
  2025-10-07  4:04 [PATCH] net/idpf: correct the enum constant name typo Shaiq Wani
@ 2025-10-07 12:46 ` Burakov, Anatoly
  2025-10-08  8:28 ` Bruce Richardson
  1 sibling, 0 replies; 3+ messages in thread
From: Burakov, Anatoly @ 2025-10-07 12:46 UTC (permalink / raw)
  To: Shaiq Wani, dev, bruce.richardson, aman.deep.singh

On 10/7/2025 6:04 AM, Shaiq Wani wrote:
> Correct the typo in the idpf_rx_func_type enum by renaming
> IDPF_RX_SINGLQ_AVX512 to IDPF_RX_SINGLEQ_AVX512 for consistency
> and improved readability.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/idpf: correct the enum constant name typo
  2025-10-07  4:04 [PATCH] net/idpf: correct the enum constant name typo Shaiq Wani
  2025-10-07 12:46 ` Burakov, Anatoly
@ 2025-10-08  8:28 ` Bruce Richardson
  1 sibling, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2025-10-08  8:28 UTC (permalink / raw)
  To: Shaiq Wani; +Cc: dev, aman.deep.singh, anatoly.burakov

On Tue, Oct 07, 2025 at 09:34:36AM +0530, Shaiq Wani wrote:
> Correct the typo in the idpf_rx_func_type enum by renaming
> IDPF_RX_SINGLQ_AVX512 to IDPF_RX_SINGLEQ_AVX512 for consistency
> and improved readability.
> 
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>

Fixes, even minor ones like this, should always start the patch title with
the word "fix" rather than "correct", for a number of reasons.
a) for consistency with other patches
b) to mark the patch as a bug fix for possible backporting
c) so that tooling such as check-git-log recognise it as a fix and run
additional checks for things like a "fixes" line with correct commit
reference.

Point "c" is especially relevant here. :-)

Fixes: 12b1c2901761 ("net/idpf: use common Rx path selection infrastructure")

Patch applied to next-net-intel with title rewording and fixline applied.

/Bruce

> ---
>  drivers/net/intel/idpf/idpf_common_device.h | 2 +-
>  drivers/net/intel/idpf/idpf_common_rxtx.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/intel/idpf/idpf_common_device.h b/drivers/net/intel/idpf/idpf_common_device.h
> index 3b95d519c6..09d59dd0c1 100644
> --- a/drivers/net/intel/idpf/idpf_common_device.h
> +++ b/drivers/net/intel/idpf/idpf_common_device.h
> @@ -50,7 +50,7 @@ enum idpf_rx_func_type {
>  	IDPF_RX_SINGLEQ_SCATTERED,
>  	IDPF_RX_SINGLEQ_AVX2,
>  	IDPF_RX_AVX512,
> -	IDPF_RX_SINGLQ_AVX512,
> +	IDPF_RX_SINGLEQ_AVX512,
>  	IDPF_RX_MAX
>  };
>  
> diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c b/drivers/net/intel/idpf/idpf_common_rxtx.c
> index a2b8c372d6..5a1c1561e5 100644
> --- a/drivers/net/intel/idpf/idpf_common_rxtx.c
> +++ b/drivers/net/intel/idpf/idpf_common_rxtx.c
> @@ -1663,7 +1663,7 @@ const struct ci_rx_path_info idpf_rx_path_infos[] = {
>  		.features = {
>  			.rx_offloads = IDPF_RX_VECTOR_OFFLOADS,
>  			.simd_width = RTE_VECT_SIMD_512}},
> -	[IDPF_RX_SINGLQ_AVX512] = {
> +	[IDPF_RX_SINGLEQ_AVX512] = {
>  		.pkt_burst = idpf_dp_singleq_recv_pkts_avx512,
>  		.info = "Single AVX512 Vector",
>  		.features = {
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-08  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-07  4:04 [PATCH] net/idpf: correct the enum constant name typo Shaiq Wani
2025-10-07 12:46 ` Burakov, Anatoly
2025-10-08  8:28 ` Bruce Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).