DPDK patches and discussions
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: <dev@dpdk.org>
Cc: <wathsala.vithanage@arm.com>, <honnappa.nagarahalli@arm.com>,
	<ola.liljedahl@arm.com>, <dhruv.tripathi@arm.com>,
	<david.marchand@redhat.com>
Subject: [PATCH v3 0/1] ring: correct ordering issue in head/tail update
Date: Mon, 10 Nov 2025 10:17:16 +0000	[thread overview]
Message-ID: <20251110101717.233685-1-konstantin.ananyev@huawei.com> (raw)
In-Reply-To: <20251002174137.3612042-1-wathsala.vithanage@arm.com>

This patch fixes a subtle ordering issue in the ring code that can lead
to incorrect behavior under certain conditions. The change adopts a
solution that balances performance with compatibility for dependent
libraries.

For background, motivation, and validation (including Herd7 litmus
tests), see the accompanying write-up:
https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/when-a-barrier-does-not-block-the-pitfalls-of-partial-order

V1->V2:
  * Switched from squashing unsafe partial orders (solution #3) to
  * establishing a pairwise happens-before relationship between the
  * producer and consumer heads (solution #2).

V2->V3 (Konstantin):
  * Added Fixes and CC to stable
  * Extend patch to cover HTS and RTS mode

Wathsala Vithanage (1):
  ring: fix unsafe ordering for head/tail update

 lib/ring/rte_ring_c11_pvt.h      | 9 +++------
 lib/ring/rte_ring_hts_elem_pvt.h | 6 ++++--
 lib/ring/rte_ring_rts_elem_pvt.h | 6 ++++--
 3 files changed, 11 insertions(+), 10 deletions(-)

-- 
2.51.0


  parent reply	other threads:[~2025-11-10 10:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 17:41 [PATCH v2 " Wathsala Vithanage
2025-10-02 17:41 ` [PATCH v2 1/1] ring: safe partial ordering for " Wathsala Vithanage
2025-10-08  8:00   ` Konstantin Ananyev
2025-10-13 18:09     ` Wathsala Vithanage
2025-11-06  8:15       ` David Marchand
2025-11-10 10:25         ` Konstantin Ananyev
2025-11-10 19:13           ` Wathsala Vithanage
2025-11-11  7:48             ` Konstantin Ananyev
2025-11-10 10:17 ` Konstantin Ananyev [this message]
2025-11-10 10:17   ` [PATCH v3 1/1] ring: fix unsafe " Konstantin Ananyev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110101717.233685-1-konstantin.ananyev@huawei.com \
    --to=konstantin.ananyev@huawei.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dhruv.tripathi@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=ola.liljedahl@arm.com \
    --cc=wathsala.vithanage@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).