[PATCH] net/ice: set pkt prepare to dummy instead of NULL

[PATCH] net/ice: set pkt prepare to dummy instead of NULL

[skori]

From: Sunil Kumar Kori <skori@marvell.com>

As per recent change by the following commit:

commit 066f3d9cc21c ("ethdev: remove callback checks from fast path")

framework unconditionally invokes dev->tx_pkt_prepare.
Due to this, ICE driver gets crashed as tx_pkt_prepare
was set to NULL during initialization.

Ensure dev->tx_pkt_prepare is not NULL when vector or simple
TX paths are selected, by assigning rte_eth_tx_pkt_prepare_dummy.

This aligns with expectations with above mentioned commit.

Bugzilla ID: 1795

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/net/intel/ice/ice_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
index fd0b3a7532..18077aca78 100644
--- a/drivers/net/intel/ice/ice_rxtx.c
+++ b/drivers/net/intel/ice/ice_rxtx.c
@@ -4131,7 +4131,7 @@ ice_set_tx_function(struct rte_eth_dev *dev)
 	}
 
 	if (ad->tx_vec_allowed) {
-		dev->tx_pkt_prepare = NULL;
+		dev->tx_pkt_prepare = rte_eth_tx_pkt_prepare_dummy;
 		if (ad->tx_simd_width == RTE_VECT_SIMD_512) {
 #ifdef CC_AVX512_SUPPORT
 			if (tx_check_ret == ICE_VECTOR_OFFLOAD_PATH) {
@@ -4177,7 +4177,7 @@ ice_set_tx_function(struct rte_eth_dev *dev)
 	if (ad->tx_simple_allowed) {
 		PMD_INIT_LOG(DEBUG, "Simple tx finally be used.");
 		dev->tx_pkt_burst = ice_xmit_pkts_simple;
-		dev->tx_pkt_prepare = NULL;
+		dev->tx_pkt_prepare = rte_eth_tx_pkt_prepare_dummy;
 	} else {
 		PMD_INIT_LOG(DEBUG, "Normal tx finally be used.");
 		dev->tx_pkt_burst = ice_xmit_pkts;
-- 
2.43.0

RE: [PATCH] net/ice: set pkt prepare to dummy instead of NULL

[Xu, HailinX]

> -----Original Message-----
> From: skori@marvell.com <skori@marvell.com>
> Sent: Monday, November 10, 2025 8:25 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [PATCH] net/ice: set pkt prepare to dummy instead of NULL
> 
> From: Sunil Kumar Kori <skori@marvell.com>
> 
> As per recent change by the following commit:
> 
> commit 066f3d9cc21c ("ethdev: remove callback checks from fast path")
> 
> framework unconditionally invokes dev->tx_pkt_prepare.
> Due to this, ICE driver gets crashed as tx_pkt_prepare was set to NULL during
> initialization.
> 
> Ensure dev->tx_pkt_prepare is not NULL when vector or simple TX paths are
> selected, by assigning rte_eth_tx_pkt_prepare_dummy.
> 
> This aligns with expectations with above mentioned commit.
> 
> Bugzilla ID: 1795
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
Tested-by: Xu, HailinX <hailinx.xu@intel.com>