From: Stephen Hemminger <stephen@networkplumber.org>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, sachin.saxena@nxp.com, stable@dpdk.org
Subject: Re: [PATCH 1/3] net/dpaa2: fix duplicate calling of dpaa2 dev close
Date: Wed, 12 Nov 2025 15:06:10 -0800 [thread overview]
Message-ID: <20251112150610.067740e6@phoenix> (raw)
In-Reply-To: <20251106163807.201451-1-hemant.agrawal@nxp.com>
On Thu, 6 Nov 2025 22:08:05 +0530
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> When rte_eth_dev_close() is called, it performs the following actions:
>
> Calls dev->dev_ops->dev_close(), which in this case is dpaa2_dev_close().
> Then calls rte_eth_dev_release_port(), which releases all device data
> and sets dev->data to NULL.
>
> Later, when rte_dev_remove() is called, the FSLMC bus invokes
> dev->remove() — that is, rte_dpaa2_remove().
> However, rte_dpaa2_remove() calls dpaa2_dev_close() again. Since dev->data
> was already set to NULL by the previous call, this second invocation
> causes a crash.
>
> Fixes: 5964d36a2904 ("net/dpaa2: release port upon close")
> Cc: sachin.saxena@nxp.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Not merging this now, because of the feedback about how this driver
is interacting with bus. Either need an ACK or new version.
next prev parent reply other threads:[~2025-11-12 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:38 Hemant Agrawal
2025-11-06 16:38 ` [PATCH 2/3] net/dpaa2: clear active VDQ state when freeing Rx queues Hemant Agrawal
2025-11-06 19:29 ` Stephen Hemminger
2025-11-07 9:51 ` Maxime Leroy
2025-11-07 10:38 ` Hemant Agrawal
2025-11-07 8:34 ` David Marchand
2025-11-06 16:38 ` [PATCH 3/3] bus/fslmc: add support for hotplug of dpni Hemant Agrawal
2025-11-07 8:32 ` [PATCH 1/3] net/dpaa2: fix duplicate calling of dpaa2 dev close David Marchand
2025-11-08 15:35 ` David Marchand
2025-11-12 23:06 ` Stephen Hemminger [this message]
2025-11-13 5:29 ` [PATCH v2 1/5] " Hemant Agrawal
2025-11-13 5:29 ` [PATCH v2 2/5] net/dpaa2: clear active VDQ state when freeing Rx queues Hemant Agrawal
2025-11-13 5:29 ` [PATCH v2 3/5] net/dpaa2: fix queue free cleanup Hemant Agrawal
2025-11-13 5:29 ` [PATCH v2 4/5] net/dpaa2: bifurcate close into close and deinit Hemant Agrawal
2025-11-13 5:29 ` [PATCH v2 5/5] bus/fslmc: add support for hotplug of dpni Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112150610.067740e6@phoenix \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).