From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C6D948AF2; Thu, 13 Nov 2025 05:39:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5768540E45; Thu, 13 Nov 2025 05:39:49 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 89BE240ECF; Thu, 13 Nov 2025 05:39:47 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AD18WT41305430; Wed, 12 Nov 2025 20:39:47 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=C nxMGWRp5RUNg0cJXcwtAnVQ8Z8g19VKQD/5zx7mx3s=; b=UpQZvlMYEU0fue9ZD FEjUdqGv56v/87KFNCbDuIFlIR/3+02REDXEVjiIXJcwSLcFSR1W7amP/EUtlswZ KxqlB0vtK78X9tOLw7oPWHDyK6Eo6ZUyGES2X45ap4U5Eav5sCjCUDE8a0FPx5qd vUjbW4jZJvjimr7qBbhoJLbw2FvjH1nne0ubm8ia88eZ6Ffh7PzliZMcd0eOZfzU IzWc2vVv/VcLjTjELlJDfV98nLxs2tOhdCNIE47HzGmq1ccpx+IFTcjYYdW3llMX gHAG7HcLGKM7qGX8a/xSZg6MiQhqsaalKcd1E4J5ImyaCyEHs/Qgi+BYPFNJ75x+ Q76wQ== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4acru1aa8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Nov 2025 20:39:46 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.25; Wed, 12 Nov 2025 20:39:46 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.25 via Frontend Transport; Wed, 12 Nov 2025 20:39:46 -0800 Received: from hyd1588t430.caveonetworks.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id CBD773F7076; Wed, 12 Nov 2025 20:39:42 -0800 (PST) From: Nithin Dabilpuram To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra CC: , , Subject: [PATCH v5 16/23] common/cnxk: fix null SQ access Date: Thu, 13 Nov 2025 10:08:01 +0530 Message-ID: <20251113043808.1180851-16-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251113043808.1180851-1-ndabilpuram@marvell.com> References: <20250901073036.1381560-1-ndabilpuram@marvell.com> <20251113043808.1180851-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Authority-Analysis: v=2.4 cv=QuFTHFyd c=1 sm=1 tr=0 ts=69156112 cx=c_pps a=gIfcoYsirJbf48DBMSPrZA==:117 a=gIfcoYsirJbf48DBMSPrZA==:17 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=M5GUcnROAAAA:8 a=8rWy6zfcAAAA:8 a=aJDCPxk_WUJAfcRIQEIA:9 a=OBjm3rFKGHvpk9ecZwUJ:22 a=YjdVzJdQTyZRADMV7wFX:22 X-Proofpoint-GUID: JzxYHWV8VRNXwBccB2OIc41yeGGQgK25 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEzMDAyOCBTYWx0ZWRfXwLRS1yZK2PRi QzQgFuum9tn52DKFC94KTvG9lDmC+jO0EQBHii5WgEVd4MdewSj/p3/YrkewLT9EDJNVokuFsKv adYZHHgv9kgIxM9IBbvYhuTGqsQFoGjz/dyYhYuKJjpr+SgcOEuFFS5+XfaKoslSkueb5FcwgS6 GxipC+Q36iYAMYGEJZi8ng6x4UnocoCI468PKwcLy2fyTZo9/ZU4Hg/kuxVha5lLc/wL2/o4OPa a0jZIXMokvLfHTP7dZyDfdVdfr7vCSRzM9jCr3ew4UxoiRmwc1gP/sp93PJO3c2uXvGTc0zHRWI P9SY99ndwnejTF/+iWzpzTwG0atz1ErWTl6lhezBpoy8ayEaJB8Kp2OYpxTk29rjVtxmAL4Ormr 940lfwn1zFMrb9S7e6/3Ki7W3meKXg== X-Proofpoint-ORIG-GUID: JzxYHWV8VRNXwBccB2OIc41yeGGQgK25 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-12_06,2025-11-12_01,2025-10-01_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Satha Rao Condition to check SQ is non NULL before access. Also pktio locks are simplified while doing threshold_profile config. Fixes: 90a903ffa6eb ("common/cnxk: split NIX TM hierarchy enable API") Cc: stable@dpdk.org Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_tm_ops.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index 09d014a276..230e9b72f6 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -624,6 +624,13 @@ roc_nix_tm_hierarchy_xmit_enable(struct roc_nix *roc_nix, enum roc_nix_tm_tree t sq_id = node->id; sq = nix->sqs[sq_id]; + if (!sq) { + plt_err("nb_rxq %d nb_txq %d sq_id %d lvl %d", nix->nb_rx_queues, + nix->nb_tx_queues, sq_id, node->lvl); + roc_nix_tm_dump(roc_nix, NULL); + roc_nix_dump(roc_nix, NULL); + return NIX_ERR_TM_INVALID_NODE; + } rc = roc_nix_sq_ena_dis(sq, true); if (rc) { plt_err("TM sw xon failed on SQ %u, rc=%d", node->id, -- 2.34.1