From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohit Kumar Parjapat <mprajapat@marvell.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>, <dev@dpdk.org>,
<jerinj@marvell.com>, <hkalra@marvell.com>
Subject: Re: [PATCH] app/proc-info: allow overriding defaults options
Date: Thu, 13 Nov 2025 09:31:00 -0800 [thread overview]
Message-ID: <20251113093100.7c3aa473@phoenix> (raw)
In-Reply-To: <20251112130326.2674728-1-mprajapat@marvell.com>
On Wed, 12 Nov 2025 18:33:13 +0530
Mohit Kumar Parjapat <mprajapat@marvell.com> wrote:
>
> +static void
> +check_user_args(int argc, char **argv, uint8_t *arg_bitmap)
> +{
> + int i;
> +
> + for (i = 1; i < argc; i++) {
> + if (strncmp(argv[i], "-l", 2) == 0)
> + *arg_bitmap |= ARG_C_FLAG;
> + else if (strncmp(argv[i], "-n", 2) == 0)
> + *arg_bitmap |= ARG_N_FLAG;
> + }
> +}
> +
There is no reason for the -n flag in this application.
Purely cargo-cult coding.
next prev parent reply other threads:[~2025-11-13 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 13:03 Mohit Kumar Parjapat
2025-11-13 17:31 ` Stephen Hemminger [this message]
2025-11-13 17:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113093100.7c3aa473@phoenix \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=mprajapat@marvell.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).