From: Stephen Hemminger <stephen@networkplumber.org>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, Christophe Fontaine <cfontain@redhat.com>, stable@dpdk.org
Subject: Re: [PATCH dpdk] net: ipv6 link local compliance with rfc 4291
Date: Fri, 14 Nov 2025 08:08:04 -0800 [thread overview]
Message-ID: <20251114080804.7636e240@phoenix> (raw)
In-Reply-To: <20251114105751.54802-3-rjarry@redhat.com>
On Fri, 14 Nov 2025 11:57:53 +0100
Robin Jarry <rjarry@redhat.com> wrote:
> @@ -406,7 +406,7 @@ rte_ipv6_llocal_from_ethernet(struct rte_ipv6_addr *ip, const struct rte_ether_a
> ip->a[0] = 0xfe;
> ip->a[1] = 0x80;
> memset(&ip->a[2], 0, 6);
> - ip->a[8] = mac->addr_bytes[0];
> + ip->a[8] = mac->addr_bytes[0] ^ 0x02;
Could use RTE_ETHER_LOCAL_ADMIN_ADDR instead of magic constant 2,
but seems a little wordy to do that.
prev parent reply other threads:[~2025-11-14 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 10:57 Robin Jarry
2025-11-14 16:05 ` Stephen Hemminger
2025-11-14 16:08 ` Robin Jarry
2025-11-14 16:14 ` Morten Brørup
2025-11-14 16:46 ` Robin Jarry
2025-11-14 17:03 ` Stephen Hemminger
2025-11-14 16:48 ` Stephen Hemminger
2025-11-14 16:08 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114080804.7636e240@phoenix \
--to=stephen@networkplumber.org \
--cc=cfontain@redhat.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).