From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: dev@dpdk.org, zaiyuwang@trustnetic.com
Subject: Re: [PATCH] net/txgbe: remove the build dependency on security
Date: Wed, 26 Nov 2025 13:39:25 -0800 [thread overview]
Message-ID: <20251126133925.7cb06815@phoenix.local> (raw)
In-Reply-To: <19590B42346A2673+20251121061951.466049-1-jiawenwu@trustnetic.com>
On Fri, 21 Nov 2025 14:19:51 +0800
Jiawen Wu <jiawenwu@trustnetic.com> wrote:
> Now lib security is enabled by default, and cannot be disabled if the
> driver is intended to be used. But there are some functional scenarios
> where lib security should be disabled, just like to enale Tx descriptor
> hardware check. See commit 0eabdfcd4af4 ("net/txgbe: enable Tx
> descriptor error interrupt").
>
> So remove the build dependency on lib security for the driver.
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
I would like a review by other maintainers.
Several other drivers including cn10k, cn20k, ixgbe already have
similar dependencies. Can't the security library just have stubs
to always return NULL if not used.
prev parent reply other threads:[~2025-11-26 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 6:19 Jiawen Wu
2025-11-26 21:39 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126133925.7cb06815@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).