DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, david.marchand@redhat.com,
	Bruce Richardson <bruce.richardson@intel.com>,
	Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Ola Liljedahl <ola.liljedahl@arm.com>, Gavin Hu <gahu@nvidia.com>,
	"Paul E. McKenney" <paulmck@linux.ibm.com>
Subject: [PATCH 1/2] rcu: fix warning on Windows builds
Date: Thu,  4 Dec 2025 11:29:02 +0000	[thread overview]
Message-ID: <20251204112904.2869502-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20251204112904.2869502-1-bruce.richardson@intel.com>

Within github actions, the following error can be reported:

...\rte_rcu_qsbr.h(566): error C2220: the following warning is treated as an error
...\rte_rcu_qsbr.h(566): warning C4319: '~': zero extending 'unsigned long' to 'uint64_t' of greater size

To fix this, replace the "1UL" with RTE_BIT64 to force a 64-bit value on
all platforms.

Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/rcu/rte_rcu_qsbr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 550fadf56a..d89a43c186 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -563,7 +563,7 @@ __rte_rcu_qsbr_check_selective(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
 			if (c != __RTE_QSBR_CNT_THR_OFFLINE && acked_token > c)
 				acked_token = c;
 
-			bmap &= ~(1UL << j);
+			bmap &= ~RTE_BIT64(j);
 		}
 	}
 
-- 
2.51.0


  reply	other threads:[~2025-12-04 11:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 11:29 [PATCH 0/2] Fix errors with updated MSVC in github actions Bruce Richardson
2025-12-04 11:29 ` Bruce Richardson [this message]
2025-12-04 11:29 ` [PATCH 2/2] net/ice: disable warning in base code for Windows builds Bruce Richardson
2025-12-04 16:31 ` [PATCH 0/2] Fix errors with updated MSVC in github actions Thomas Monjalon
2025-12-04 17:04   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204112904.2869502-2-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gahu@nvidia.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=konstantin.ananyev@huawei.com \
    --cc=ola.liljedahl@arm.com \
    --cc=paulmck@linux.ibm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).