From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F078A0A0A; Fri, 22 Jan 2021 09:59:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB7AC140D98; Fri, 22 Jan 2021 09:58:59 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 6D57D140CDC for <dev@dpdk.org>; Fri, 22 Jan 2021 09:58:58 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 9BB5358050E; Fri, 22 Jan 2021 03:58:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 22 Jan 2021 03:58:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= DbV3K/uWXb4zbwyvlKv2TBNZhNo6pWYqzg0hI3djRYc=; b=0jFcIbtOwnRTRj3H tASSah5pT2A6ClusUK2EHgEJmZkkLdY7h05NFUgby0zIGkmPE7QbHxyEsPci7OY1 +pj14r3vGkVTvke/YABgU+7XHT7JlqNSTW6oyoO32QfH9PlYpanjLAyUIp6xgW1N A1pLZgQbc/YoABpvSPnxAEd5x5eRu755ZgDUhypa2T410dgZ6737rfELBjBr/+dP FYKcfXFPj23BohAxPMPIKNYOThs4dlrJaBpHUId57FlIzVGNkSCt8d1896CFxXjs fU/l7J9EhPM/7pwvQdxpc3mWEZluIwWW2aivLn8EpTDxyid3FzIydP0Hp+VsAhKC FJXSiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DbV3K/uWXb4zbwyvlKv2TBNZhNo6pWYqzg0hI3djR Yc=; b=QwYY+PwnRlTc2lvYetZUiCczTNDy0mnKcJNZxU3EubshP3EUEOW9V1kQG Y5AxAWWCpCwmT0JR08rxoGiKQng9KAILcmdxK/criHoefR/vCUXLavMkA9ou632o VKiq87teqoxbXboP5fXjtof8HlVudiGd5b5xXwuTEmYbnlX8Ne2t+gA68j63oWhx YhosARnFuqcc6dWP/ij+UkA8PGF2Rm2jZHlex0SUAX3CDs/ozmoYRn75HnnI6Ytj z2oxvPzcl4KOtvUaEx4T6uzQrPO0dKtZonv+AH6S7lLMf0lAVCeGb+bqp268MO// Y8lUwpgfqDQ0XfwDQ72FaPi4dupAA== X-ME-Sender: <xms:z5MKYKcAuh8cY7-INIqnUftEWLFM3Y7di7l5wjmVe9r7SJcRhv2TmA> <xme:z5MKYENtslJge1v775lnKxKbGQZzWuMNh0x74PLqujaK6EQlkLJqzPDFNsnVJc14_ g4kJxRCD_hHPVqVzQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehgdduvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:z5MKYLgPR082tjsr7lc2W7vpY6NxrjJDBVbmQ_CX3BxftgeRbFsNLA> <xmx:z5MKYH9t5OulVfv65m94_XwEe7d4VA6r-XSwdyAJuaRPNHFTOZ1aoQ> <xmx:z5MKYGt9-vkMRMgyAUwXAuh5gLE2bz30xhFGwSLzt5JDgGqmteFDKA> <xmx:0JMKYLMf_eliz2GcZpzbnt2PZOttVWe3sxR1OyNPxO2k5MTQwn4Cng> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0749D24005C; Fri, 22 Jan 2021 03:58:53 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Juraj =?utf-8?B?TGlua2XFoQ==?= <juraj.linkes@pantheon.tech> Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, Phil Yang <Phil.Yang@arm.com>, "vcchunga@amazon.com" <vcchunga@amazon.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>, "jerinjacobk@gmail.com" <jerinjacobk@gmail.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Ajit Khaparde (ajit.khaparde@broadcom.com)" <ajit.khaparde@broadcom.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "aboyer@pensando.io" <aboyer@pensando.io>, "dev@dpdk.org" <dev@dpdk.org>, "lironh@marvell.com" <lironh@marvell.com>, "allain.legacy@windriver.com" <allain.legacy@windriver.com>, nd <nd@arm.com> Date: Fri, 22 Jan 2021 09:58:52 +0100 Message-ID: <2025364.IVKG2jy1nW@thomas> In-Reply-To: <d8fea4d94d1346a1ac8017e5cd5cb5b6@pantheon.tech> References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <DBAPR08MB5814E779855E522ACCD27ADD98A20@DBAPR08MB5814.eurprd08.prod.outlook.com> <d8fea4d94d1346a1ac8017e5cd5cb5b6@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 22/01/2021 09:39, Juraj Linke=C5=A1: > > > > > disabled drivers, similarly how the command line option works and > > > > > remove unneeded driver options ported from the old makefile > > > > > system, since they don't work in the current Meson build system. > > > > > Add support for removing drivers for cross builds so that we can > > > > > disable them in cross files. > > > > > > > > Why disabling them? > > > > If a driver is not supported it should disable itseld in its meson = file. > > > > > > > > > > This is helpful when building for an SoC where we don't want to build > > > to build a driver, but the build machine actually supports the driver. > > > I believe in this case the meson build system would find the > > > dependencies and designate the driver to be build, but we don't want = to build > > the driver for that SoC. > > > > > > There may be other reasons as well - Honnappa or others from the Arm > > > community may shed more light on this. > > IMO, the assumption should be everything compiles on all the platforms.= Hence, > > the disables should be applied to the platforms where the drivers do not > > compile. If a driver does not compile, it can disable itself. No need for a configuration. > Would it be okay to leave the disabled as they're in this commit and leav= e the updates to the plaform owners? Thomas, what do you think? I think this patch should not disable drivers but just add the infra to do = it.