From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 983872C12 for ; Wed, 25 Apr 2018 00:34:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C4D6B212A0; Tue, 24 Apr 2018 18:34:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 Apr 2018 18:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=wnDKNuUwkZdFGZCiObwHpm8f5D xyuTk9FywK5BcXQLE=; b=LZjihhUfZEdCXiAk33wyx0kESqa+9Pu5eQoc8HcAE2 tFMqCo+IDOayqa2Vv45AL+nhelmuHJJTCtAnZDlsVw+RiEzn70NQ6LrQShjQLvtr cmo0NqJPS2m08eTHTEx2EnIyoK0JlxXEK5krl7+asqiUYzWg2CM9DxK4G9PZzyLE o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wnDKNu UwkZdFGZCiObwHpm8f5DxyuTk9FywK5BcXQLE=; b=aPfGloCuODm+rkD+20sKYq gKKgvw6MhlVHJVGV+/JXUmvBPY8R2ptEc5boHhgXv8FIRZVefzKjjhXHVFaRHA7Y rrts0OiKa+iPwrE6x2vUDNd/aAW7bg+mK/OMHKIeBcIJ8fakicfucNQ1UQq5nkTJ ET+GOc+8nteRZg+obOb5X5l5490HfJB5o6FAaoonfU38gf3JzXtIDdFoT2rW/gp2 1SAUYNFmLbKSfAnesfEuaDJzku+xJlCwvWOdvms3kx5e+9CO67Ilp7fxQuibYsBz P33LmH/ewicr+pEl5VME0K04+Sf+hkivKmHXN0YT+GoqbftOfkX3tPY2nQU/6pGg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E7605E47A0; Tue, 24 Apr 2018 18:34:12 -0400 (EDT) From: Thomas Monjalon To: "Pattan, Reshma" Cc: dev@dpdk.org, "Hunt, David" , "Richardson, Bruce" , "Parthasarathy, JananeeX M" Date: Wed, 25 Apr 2018 00:34:11 +0200 Message-ID: <2027071.Zq3VvV6ELG@xps> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C9138@irsmsx110.ger.corp.intel.com> References: <1523022706-12231-1-git-send-email-reshma.pattan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2C9138@irsmsx110.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 22:34:14 -0000 24/04/2018 14:51, Pattan, Reshma: > From: Hunt, David > > On 24/4/2018 12:23 PM, Pattan, Reshma wrote: > > > From: Richardson, Bruce > > >> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote: > > >>> 11/04/2018 16:14, Reshma Pattan: > > >>>> Unit Testcases are added for power_acpi_cpu_freq, > > power_kvm_vm_test > > >>>> to improve coverage > > >>>> > > >>>> Signed-off-by: Jananee Parthasarathy > > >>>> > > >>>> Acked-by: David Hunt > > >>> Applied, thanks > > >>> > > >> Sadly, this patch seems to break shared library builds. If you try > > >> doing "make test-build" with shared libraries on it will fail, or if > > >> you do a meson build using shared libraries you will get the same result. > > >> > > >> The root cause is that the function guest_channel_host_connect() is a > > >> private function and so is not listed in the shared library map file, > > >> preventing the test app from linking. > > >> > > > Any action from my side required? Let me know. > > > > Reshma, > > Looking at this, I think this particular unit test needs to be removed. The > > way it is at the moment, it's "faking" the connect, then any commands that > > are sent to the dummy host are only really to test to see if the API breaks, > > which is going to be captured by compilation tests anyway. I don't see the > > value of this unit test unless you have the full host setup underneath is, in > > which case it's no longer a unit test. > > Also, we don't want to make these functions public, as they are only of use to > > the library internally, and there is no use for them publicly (unless a guest > > wants to fake a connection to a non-existent host). > > > > What do you think? > > Fine, we are reverting the changes and will send the patch soon. Where is the patch? I will revert it myself.