From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 267492E89 for ; Mon, 3 Nov 2014 19:28:20 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id hi2so7229612wib.13 for ; Mon, 03 Nov 2014 10:37:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=am2ztCtGWi/DAojWQ4DyeW7x9jnVevIIHO5CmcKrGY0=; b=H81P1AU2heo66dG1WO66H7ZH6YnKRXG8WQOY8WpWXAFiUgkCyawiuCOQ8ITZO9q3La jB1nCMIxMYeo/P743DX09/loICzkXwolFY8CGahQG6WdKTFJMp2K6cSviRDjLTNUbzuN PLEmQyhNnL8FxNhW9J8qsJewaFAmzxHUP51+9Z2amntldIOBZV1WZXXV0/r1DzDIuNWq f+rLRq2u9ho+IA8nwUpxs7Tk2FiuX08iUI5g9u9sggYjC7Ly+cS7asQHPQ+GKZDdIRkb CsxU8VRIESJOgOSwbDmQcZ8jlMPIm6e5w1vaDpO2YfFsUqeVTVY/8WQ8DBi314Fx8rVK vUQA== X-Gm-Message-State: ALoCoQmks841Sd66XGNTQTW85dxhM7fBajqfgQVy+z237w9Rt6KJMrZFQspNWJmFHS1VRNqTVcYT X-Received: by 10.180.106.104 with SMTP id gt8mr18050809wib.51.1415039855201; Mon, 03 Nov 2014 10:37:35 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id b6sm9606416wiy.22.2014.11.03.10.37.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Nov 2014 10:37:34 -0800 (PST) From: Thomas Monjalon To: "Chen Jing D(Mark)" Date: Mon, 03 Nov 2014 19:37:16 +0100 Message-ID: <2027422.tgQyvDmmaG@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1413454046-13407-3-git-send-email-jing.d.chen@intel.com> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <1413454046-13407-1-git-send-email-jing.d.chen@intel.com> <1413454046-13407-3-git-send-email-jing.d.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/6] igb: change for VMDQ arguments expansion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 18:28:20 -0000 2014-10-16 18:07, Chen Jing D: > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -1286,18 +1286,21 @@ eth_igb_infos_get(struct rte_eth_dev *dev, > dev_info->max_rx_queues = 16; > dev_info->max_tx_queues = 16; > dev_info->max_vmdq_pools = ETH_8_POOLS; > + dev_info->vmdq_queue_num = 16; > break; > > case e1000_82580: > dev_info->max_rx_queues = 8; > dev_info->max_tx_queues = 8; > dev_info->max_vmdq_pools = ETH_8_POOLS; > + dev_info->vmdq_queue_num = 8; > break; > > case e1000_i350: > dev_info->max_rx_queues = 8; > dev_info->max_tx_queues = 8; > dev_info->max_vmdq_pools = ETH_8_POOLS; > + dev_info->vmdq_queue_num = 8; > break; Why not simply set it only once? dev_info->vmdq_queue_num = dev_info->max_rx_queues; -- Thomas