DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor
@ 2021-04-23 11:01 Anatoly Burakov
  2021-04-28 15:41 ` Pattan, Reshma
  0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2021-04-23 11:01 UTC (permalink / raw)
  To: dev; +Cc: Richael.Zhuang, david.hunt

Currently, when we set the acpi governor to "userspace", we check if
it is already set to this value, and if it is, we skip setting it.

However, we never save this value anywhere, so that next time we come
back and request the governor to be set to its original value, the
original value is empty.

Fix it by saving the original pstate governor first. While we're at it,
replace `strlcpy` with `rte_strscpy`.

Fixes: 445c6528b55f ("power: common interface for guest and host")
Cc: david.hunt@intel.com

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/power/power_acpi_cpufreq.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c
index 84a9d75207..d028a9947f 100644
--- a/lib/power/power_acpi_cpufreq.c
+++ b/lib/power/power_acpi_cpufreq.c
@@ -152,6 +152,9 @@ power_set_governor_userspace(struct rte_power_info *pi)
 	/* Strip off terminating '\n' */
 	strtok(buf, "\n");
 
+	/* Save the original governor */
+	rte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori));
+
 	/* Check if current governor is userspace */
 	if (strncmp(buf, POWER_GOVERNOR_USERSPACE,
 			sizeof(POWER_GOVERNOR_USERSPACE)) == 0) {
@@ -160,8 +163,6 @@ power_set_governor_userspace(struct rte_power_info *pi)
 				"already userspace\n", pi->lcore_id);
 		goto out;
 	}
-	/* Save the original governor */
-	strlcpy(pi->governor_ori, buf, sizeof(pi->governor_ori));
 
 	/* Write 'userspace' to the governor */
 	val = fseek(f, 0, SEEK_SET);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor
  2021-04-23 11:01 [dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor Anatoly Burakov
@ 2021-04-28 15:41 ` Pattan, Reshma
  2021-05-05 10:26   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Pattan, Reshma @ 2021-04-28 15:41 UTC (permalink / raw)
  To: Burakov, Anatoly, dev; +Cc: Richael.Zhuang, Hunt, David



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
> +	/* Save the original governor */
> +	rte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori));
> +

Acked-by: Reshma Pattan <reshma.pattan@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor
  2021-04-28 15:41 ` Pattan, Reshma
@ 2021-05-05 10:26   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-05-05 10:26 UTC (permalink / raw)
  To: Burakov, Anatoly; +Cc: dev, Richael.Zhuang, Hunt, David, Pattan, Reshma

28/04/2021 17:41, Pattan, Reshma:
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Anatoly Burakov
> > +	/* Save the original governor */
> > +	rte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori));
> > +
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-05 10:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 11:01 [dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor Anatoly Burakov
2021-04-28 15:41 ` Pattan, Reshma
2021-05-05 10:26   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).