From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 8CE255938 for ; Mon, 5 Jan 2015 16:59:32 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id b13so27763119wgh.4 for ; Mon, 05 Jan 2015 07:59:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=CoiX3a/BkXIz9t4S7wJYehvIiL/iiMAdXYtgrGToycE=; b=RM1Zxhlvl2lGGHcRrIzWfcqwsm5vN46kLWY3KoNxpesrQdo4rXMaOAi6Dbjo30LFiQ QCdBj/+lFCaUqiEap+ufi10J22ag8v2bY0Lf1wCb83e049+dmUfQCGdGWlC24Me+pOd7 jiDC80Rsa/CK/ID/sRaER/cEAeedKNyK8/kmK+4IZzuxgtPxvNf3A6cuHxB7sp7ih1pd 6h+ujG+YkMuFMI+ec6zpBUX1IZbz3NtafYAwtxByjDjoH9JKBI3hbSZPIlCry1vTHK7x lH33ZCVYidIaLuCsflZS2iERyTqRBwkiHUJxnuOQoo73utSdImBLuSnrSu57y2bYaeLq 7Fqw== X-Gm-Message-State: ALoCoQm97wNQ8zzhDAXrcfTWRJ9TYMHoFhY1ucv70HSq01Lq/DwkP6lsGl6Hc35ghCe3r5C5Y9CX X-Received: by 10.180.81.169 with SMTP id b9mr27181022wiy.41.1420473572416; Mon, 05 Jan 2015 07:59:32 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id i3sm10402923wie.23.2015.01.05.07.59.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 07:59:31 -0800 (PST) From: Thomas Monjalon To: Ravi Kerur Date: Mon, 05 Jan 2015 16:59:10 +0100 Message-ID: <20293089.lIc3yRvdMZ@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1419521597-31978-5-git-send-email-rkerur@gmail.com> References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <1419521597-31978-5-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 4/7] Move EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 15:59:32 -0000 2014-12-25 10:33, Ravi Kerur: > Move common functions in eal.c to librte_eal/common directory. [...] > lib/librte_eal/common/eal_common.c | 328 ++++++++++++++++++++++++++++++++++ > lib/librte_eal/common/eal_externs.h | 42 +++++ I don't agree with these new files. We must try to keep a semantic organization. The file eal_common_options.c would be better for option-related functions. Maybe that the split between system config, runtime config and internal config must be reworked. By the way, it would be nice to avoid extern variables. -- Thomas