From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Wisam Monther <wisamm@nvidia.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors
Date: Wed, 24 Feb 2021 15:38:22 +0000 [thread overview]
Message-ID: <202a4cbe-44e7-42a9-9da1-ad62269ba78c@intel.com> (raw)
In-Reply-To: <CADyeNED_8JFTwF3wz=sWyAcU1eXPD6mwTZhzspDsPJveXfGAeA@mail.gmail.com>
On 2/24/2021 3:16 PM, Lance Richardson wrote:
>> Lance, can you spare some time to make the above mentioned patch?
>
> Sure. Are you looking for something like the changes below, or also including
> a search and replace of the deprecated macro name with the new one?
>
Thank you.
Yes below looks good, and I think we should have the search & replace of the old
macro usage, the latest upstream code shouldn't have the deprecated macro.
> - /** External IP header checksum error. */
> +/**
> + * Deprecated.
> + * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
> + */
> +#define PKT_RX_EIP_CKSUM_BAD (1ULL << 5)
> +
> +/**
> + * This flag is set when the outermost IP header checksum is detected as
> + * wrong by the hardware.
> + */
> #define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5)
>
> /**
>
prev parent reply other threads:[~2021-02-24 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 22:35 Lance Richardson
2021-01-31 11:53 ` Wisam Monther
2021-02-23 18:35 ` Ferruh Yigit
2021-02-23 18:39 ` Ajit Khaparde
2021-02-23 20:25 ` Thomas Monjalon
2021-02-24 10:12 ` Ferruh Yigit
2021-02-24 15:16 ` Lance Richardson
2021-02-24 15:38 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202a4cbe-44e7-42a9-9da1-ad62269ba78c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=lance.richardson@broadcom.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=wisamm@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).