From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 814D4A054F; Wed, 24 Feb 2021 16:38:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5159E4069B; Wed, 24 Feb 2021 16:38:44 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6DBF140040 for ; Wed, 24 Feb 2021 16:38:43 +0100 (CET) IronPort-SDR: /8YOIO3KxERq0knZ3Hnzg+5oeGbCi3tb6zyx7bkJojLAIpAuESA8+y9CjT95tEFBBiPerpP/m0 KhSZ7e+2lqSg== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="246617485" X-IronPort-AV: E=Sophos;i="5.81,203,1610438400"; d="scan'208";a="246617485" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 07:38:41 -0800 IronPort-SDR: CW45obb5J5D3+N9SzNXAGipExOW2YcEtbESrIp8b1Hw5Ycz8UbFUNOgLobi6001m7smjAQi/L8 n8MghFrNfu7Q== X-IronPort-AV: E=Sophos;i="5.81,203,1610438400"; d="scan'208";a="442124827" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.253.18]) ([10.213.253.18]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 07:38:38 -0800 To: Lance Richardson Cc: Thomas Monjalon , Ajit Khaparde , Wisam Monther , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger , Olivier Matz , Andrew Rybchenko , "dev@dpdk.org" , Kalesh Anakkur Purayil References: <20210129223554.103012-1-lance.richardson@broadcom.com> <2946497.zBJjzZiKe1@thomas> <64df8a5a-9599-927b-6408-d2dfd6e29221@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <202a4cbe-44e7-42a9-9da1-ad62269ba78c@intel.com> Date: Wed, 24 Feb 2021 15:38:22 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/24/2021 3:16 PM, Lance Richardson wrote: >> Lance, can you spare some time to make the above mentioned patch? > > Sure. Are you looking for something like the changes below, or also including > a search and replace of the deprecated macro name with the new one? > Thank you. Yes below looks good, and I think we should have the search & replace of the old macro usage, the latest upstream code shouldn't have the deprecated macro. > - /** External IP header checksum error. */ > +/** > + * Deprecated. > + * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead. > + */ > +#define PKT_RX_EIP_CKSUM_BAD (1ULL << 5) > + > +/** > + * This flag is set when the outermost IP header checksum is detected as > + * wrong by the hardware. > + */ > #define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5) > > /** >