From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 4111E5F11 for ; Fri, 26 Oct 2018 01:32:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CE5C2D12; Thu, 25 Oct 2018 19:32:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 19:32:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DOG91PgzbgA2IPQiDKvkSUW7QUKOobH2AZPR1qlWuVQ=; b=WohEXGpG5T3H Ze2geuxRJgLVAmFekCg3EKal/D4SOY0fViqj8lAoK3z2MFHd+Qku+WqlAleguSlF 4/FMlGbGGzXMJ9TCCv2RhKkS4+BgmWO5bILcNHsUVUSU0tpfD0Pp99kg7rDy4nPQ wLymqlXcD+tf0ixIQmJR3Z2Gjm2GXMg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DOG91PgzbgA2IPQiDKvkSUW7QUKOobH2AZPR1qlWu VQ=; b=VPhcMN6u2xGO1HpGQRZN72GsP2IIsMpirSTgy0yDrFmOsxXPJD1Dwv1MD ddq3M1552vZb55dxQs2gdl8cuvZ0HxWnoiQmTyM/QDsEaI+VG3g4ars/+kn+2Z58 xxNkenreaQHVYznLpIYCnjhlh+EstWL2doby4Bho7NYvf08oigpmxGdbo3pRZOPo VcrMYhaiHwL3uZ+W0/mWMPbsprpcS48j6ywl702TJT0UJek1uHsJjMXTDKO8pLpn quFm+73tHxUZEL0RxqlRtDIAFNh8fD3NtQp2YOzwsRPl2Pf9mFSV7/jrhUHAcdcx I3YI27YsniWvsd/y4xH7YnYYgXwGw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C6B6FE4897; Thu, 25 Oct 2018 19:32:20 -0400 (EDT) From: Thomas Monjalon To: Liang Ma Cc: dev@dpdk.org, david.hunt@intel.com, lei.a.yao@intel.com, ktraynor@redhat.com, marko.kovacevic@intel.com Date: Fri, 26 Oct 2018 01:32:22 +0200 Message-ID: <2031223.gnKAPLfQHy@xps> In-Reply-To: <2963009.GYir0F1WiB@xps> References: <1539944630-21625-1-git-send-email-liang.j.ma@intel.com> <1539947242-16729-1-git-send-email-liang.j.ma@intel.com> <2963009.GYir0F1WiB@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 23:32:24 -0000 26/10/2018 01:22, Thomas Monjalon: > Hi, > > It fails to compile (tried with meson build-gcc-static): > > lib/librte_power/rte_power_empty_poll.h:20:10: fatal error: > rte_timer.h: No such file or directory > > It looks to be fixed with this one-line change: > > --- a/lib/librte_power/meson.build > +++ b/lib/librte_power/meson.build > @@ -8,3 +8,4 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c', > 'power_kvm_vm.c', 'guest_channel.c', > 'rte_power_empty_poll.c') > headers = files('rte_power.h','rte_power_empty_poll.h') > +deps += ['timer'] There are also some doxygen issues: lib/librte_power/rte_power_empty_poll.h:136: warning: Found unknown command `\freq_tlb' lib/librte_power/rte_power_empty_poll.h:138: warning: Found unknown command `\policy' lib/librte_power/rte_power_empty_poll.h:146: warning: The following parameters of rte_power_empty_poll_stat_init(struct ep_params **eptr, uint8_t *freq_tlb, struct ep_policy *policy) are not documented: parameter 'freq_tlb' parameter 'policy'