DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>,
	david.marchand@redhat.com
Subject: Re: [PATCH] eal: remove unnecessary argv[0] handling
Date: Wed, 09 Feb 2022 15:58:26 +0100	[thread overview]
Message-ID: <2032198.bB369e8A3T@thomas> (raw)
In-Reply-To: <20220202194738.404876-1-stephen@networkplumber.org>

02/02/2022 20:47, Stephen Hemminger:
> The rte_eal_init function looks at argv[0] to determine
> the program name to pass to the log init function.
> This is both unnecessary and in a corner case a problem.
> 
> Parsing argv[0] is unnecessary because the function openlog()
> already determines the log identifier from program name if
> NULL is passed, see openlog man page:
>     The string pointed to by ident is prepended to every message, and is
>     typically set to the program name. If ident is NULL, the program name
>     is used.  (POSIX.1-2008 does not specify the behavior when ident is
>     NULL.)

What about POSIX warning?
Did you test it? Which libc? What about musl?

[...]
> -	if (eal_log_init(logid, internal_conf->syslog_facility) < 0) {
> +	if (eal_log_init(NULL, internal_conf->syslog_facility) < 0) {

We could completely remove the logid parameter.




  reply	other threads:[~2022-02-09 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 19:47 Stephen Hemminger
2022-02-09 14:58 ` Thomas Monjalon [this message]
2022-02-09 15:36   ` Stephen Hemminger
2022-02-09 15:45   ` Stephen Hemminger
2022-02-09 18:51     ` Thomas Monjalon
2022-02-09 19:29       ` Stephen Hemminger
2022-02-10  7:57         ` Thomas Monjalon
2022-02-09 15:54 ` [PATCH v2] Subject: " Stephen Hemminger
2022-02-09 20:41 ` [PATCH v3] eal: simplify " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2032198.bB369e8A3T@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).