From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC0CBA0A0E; Mon, 10 May 2021 15:25:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64D7240140; Mon, 10 May 2021 15:25:52 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id AE3D14003E for ; Mon, 10 May 2021 15:25:50 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 07936127B; Mon, 10 May 2021 09:25:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 10 May 2021 09:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= S9vY1bCbdH87rSH/WzuE3xDJVBsuOkcr2zUn8mw9xuc=; b=YaQszBdw/QjMLMca Ov3eRi7AIMdtRnsP6/GgIdh/g+AZz4cK2HQSq0MMtpBi8gCp9G0O0lfDYB7gI9Sp SGVU1CfBfmpTz3ax2h9nhTaelh2hiOdAs5fiOBXp51hXzwBDJ/TPvljrSfO46KIA Kx6Fo0me0ceKiwDzq5V1KEmRVdLyHSECl7PHUzUYTrGNolRom27tDwc6cQn2mMe/ t+DZXfTavpQLIQZ51GpNWotGkIDItLw2lCRt1dnVoYw1DTdGY0DEGEmiDtxzc9r5 4sEj9k278p9JP9BEV+KF5cWdvY7Fs+cEM29APHFksCM7qAuFE5jlVNK8hukSugLC zBPmNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=S9vY1bCbdH87rSH/WzuE3xDJVBsuOkcr2zUn8mw9x uc=; b=ihPYDwRZkVuh9l23D9tOyXDlerZ7jrIZ6koWTCRRY24PKt+YUlaRC9+KW l4NpKtJkR8HsiTKYTJAlW0khT8oIf3UiwjcS/8EO22+zO+GAMCPGCaoLnue1yQom i6nJZLMYRZl3mPx+WEk8+XXYtCnYO/3SVF35Ag/3fHgmioIYWJScdbicL6Z3kwrW VGkCnm43fnTEKVEa6m8qvUgqoxRqMaJsw5Y+9tDnBrWHqtTsylq644a4BUU7o9Qs cSM5je+QD6q2Vtkbg8A1oXtnkrW3UndxWVW3z/Z4/MZ10qlCAhrjbVbhuyZ5f4uP RoPQmKfzSZboVtPcXR2eKRX9efzew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegkedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 May 2021 09:25:47 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, konstantin.ananyev@intel.com, andrey.chilikin@intel.com, ray.kinsella@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, kda@semihalf.com Date: Mon, 10 May 2021 15:25:46 +0200 Message-ID: <2033179.CKzPTzZ2rV@thomas> In-Reply-To: <1620301222-209584-1-git-send-email-vladimir.medvedkin@intel.com> References: <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com> <1620301222-209584-1-git-send-email-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] hash: fix tuple adjustment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/05/2021 13:40, Vladimir Medvedkin: > rte_thash_adjust_tuple() uses random to generate a new subtuple if > fn() callback reports about collision. In some cases random changes > the subtuple in a way that after complementary bits are applied the > original tuple is obtained. This patch replaces random with subtuple > increment. > > Fixes: 28ebff11c2dc ("hash: add predictable RSS") > Cc: vladimir.medvedkin@intel.com > > Signed-off-by: Vladimir Medvedkin > Acked-by: Yipeng Wang > Tested-by: Stanislaw Kardach > Reviewed-by: Stanislaw Kardach Applied, thanks