From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id C9D5AE72 for <dev@dpdk.org>; Mon, 13 Jul 2015 14:37:29 +0200 (CEST) Received: by wgjx7 with SMTP id x7so294832831wgj.2 for <dev@dpdk.org>; Mon, 13 Jul 2015 05:37:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=pTG4sMrzgKXrMFBvtwx0E+X6CpgjWnfEUQnRI9XGnLc=; b=BgenysSg94xSjI3N363r0DSA3ZG+Qyp2W2YrwDBTZdzy3nLz0BfiE2rynlTT8e29X8 xeuT0XFdyrAfOWXMD9QL8p1oYaDnIe6L1/S0MTA5m/p0InQxU9qn3b9INAUhZpRamZi5 +ZnwbZ81Sd/HupT3pg77zJ2N/yaoNLnqbl9VR/SEUYbpFoldwqOAwYDSjUtvMkhJLOQ3 jcEKmfV69T9S8wP4/56ep/yS9ij6rcigYi6dsp6dKQR7rB27VzIdHmbFH4KWJqsuYUmY ody97TFybRdhK9Gxbm5csGnrKaJU5PNsqQpz93d8AEnZzC/PtxH1zuQO3vlB2R8WH7MH Xuxg== X-Gm-Message-State: ALoCoQkX72uy3GjUaFSt5Tqbb8PagRmWXPWYXdW4wMK7Yh+pzTeHOjfW8s6+k1WQSQX0NGohWuxf X-Received: by 10.180.10.200 with SMTP id k8mr22521177wib.14.1436791049673; Mon, 13 Jul 2015 05:37:29 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id lq9sm28976903wjb.35.2015.07.13.05.37.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 05:37:28 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Tomasz Kulasek <tomaszx.kulasek@intel.com> Date: Mon, 13 Jul 2015 14:36:15 +0200 Message-ID: <2033219.3PlE3JM2PJ@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1435589444-1988-3-git-send-email-tomaszx.kulasek@intel.com> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-3-git-send-email-tomaszx.kulasek@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 13 Jul 2015 12:37:30 -0000 2015-06-29 16:50, Tomasz Kulasek: > This implementation allows to set and read RSS configuration for ring > device, and is used to validate right values propagation over the slaves, > in test units for dynamic RSS configuration for bonding. > > It have no impact on packet processing by ring device. Adding some fake RSS to the ring PMD (in order to test bonding) is weird. The ring PMD is not a driver for testing. Maybe that the null PMD would be more appropriate. By the way the current RSS implementation is really bound to Intel devices. Before applying it to more drivers, we have to make sure it is generic enough. Maybe the RETA needs more abstraction.