DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler
@ 2015-11-20 14:02 Thomas Monjalon
  2015-11-20 15:40 ` Olivier MATZ
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2015-11-20 14:02 UTC (permalink / raw)
  To: olivier.matz; +Cc: dev

When using a linker option not known by the compiler like -rpath,
the library linkage was failing.
It is fixed by prefixing the option with -Wl, as it is done in other
makefiles.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/rte.lib.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index fcc8e20..06a1519 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -68,6 +68,7 @@ ifeq ($(LINK_USING_CC),1)
 # Override the definition of LD here, since we're linking with CC
 LD := $(CC) $(CPU_CFLAGS)
 _CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
+override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
 else
 _CPU_LDFLAGS := $(CPU_LDFLAGS)
 endif
-- 
2.5.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler
  2015-11-20 14:02 [dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler Thomas Monjalon
@ 2015-11-20 15:40 ` Olivier MATZ
  2015-11-20 16:17   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Olivier MATZ @ 2015-11-20 15:40 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

Hi,

On 11/20/2015 03:02 PM, Thomas Monjalon wrote:
> When using a linker option not known by the compiler like -rpath,
> the library linkage was failing.
> It is fixed by prefixing the option with -Wl, as it is done in other
> makefiles.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  mk/rte.lib.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index fcc8e20..06a1519 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -68,6 +68,7 @@ ifeq ($(LINK_USING_CC),1)
>  # Override the definition of LD here, since we're linking with CC
>  LD := $(CC) $(CPU_CFLAGS)
>  _CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
> +override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
>  else
>  _CPU_LDFLAGS := $(CPU_LDFLAGS)
>  endif
> 

Acked-by: Olivier Matz <olivier.matz@6wind.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler
  2015-11-20 15:40 ` Olivier MATZ
@ 2015-11-20 16:17   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-11-20 16:17 UTC (permalink / raw)
  To: Olivier MATZ; +Cc: dev

2015-11-20 16:40, Olivier MATZ:
> On 11/20/2015 03:02 PM, Thomas Monjalon wrote:
> > When using a linker option not known by the compiler like -rpath,
> > the library linkage was failing.
> > It is fixed by prefixing the option with -Wl, as it is done in other
> > makefiles.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-20 16:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-20 14:02 [dpdk-dev] [PATCH] mk: fix extra options when linking lib through compiler Thomas Monjalon
2015-11-20 15:40 ` Olivier MATZ
2015-11-20 16:17   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).