From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45F10A00E6 for ; Wed, 10 Jul 2019 09:30:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A0A7231E; Wed, 10 Jul 2019 09:30:02 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 3808A1C01 for ; Wed, 10 Jul 2019 09:30:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2A3EE4A0; Wed, 10 Jul 2019 03:29:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 10 Jul 2019 03:29:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=OR9+1EMyPSfM92m/1Rc2BDFwYO/mYoHkmB9U4b5JEeA=; b=g0KP8kmCvkHC 7q+E+qHuFq6GPVtfpEyKMIhdyejtfWoXJZaDPWuaVzAbONgJbe2almlY4O9Amsmm lVUJ8/5372/ejgmsIB7LFwtnxAJilV6tgk8YIBosCwox9OhtHUzaNUIsXLe3MdkC 9XC+bAqxcIWwCaOie8+EHiByn/IK+jI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=OR9+1EMyPSfM92m/1Rc2BDFwYO/mYoHkmB9U4b5JE eA=; b=DETML1TzFqzo689eErxIxL9t6eEacT9CxyF2p6DxXq+d+j5lbRAnqMCX4 /UvurdJ2jfwo7bpnROcYAP5rfCOCgZjG+p+w2vTRdscIdUgpJKoceDfCl/AZpnTo ZO/4JrLRVNEEdY2p/l/zDb4L9kdFE6WuqTTRWrzNwFFv7fsJV8gXsaq3A44+RwT7 CtCvmaH0sG/uA62QDcYqubmHx8r7Whem5E+g2Wmbs70ZAHA7fuifGJTtqWT3KdDC +7IEeZHNKk+rEIjehYGXVUzYnypb3/9vDOLI1UFty/wKoi2F2IXqZxEimwyLHABw 7KKeWHQ3gnnrIGbNID8NnBAibpC3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeehgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CE6D5380086; Wed, 10 Jul 2019 03:29:57 -0400 (EDT) From: Thomas Monjalon To: Qiming Yang Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Wed, 10 Jul 2019 09:29:56 +0200 Message-ID: <2036459.gTkXSRM7NQ@xps> In-Reply-To: <20190709040812.4191-1-qiming.yang@intel.com> References: <20190709040812.4191-1-qiming.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/ice: fixed wrong return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 09/07/2019 06:08, Qiming Yang: > Fixed error return value check and wrong error message. > > Fixes: d76116a4678f ("net/ice: add generic flow API") > > Signed-off-by: Qiming Yang Comments about the formatting of the title: The verb must be in infinitive form: "fix". The title must say which behaviour is fixed, not the code detail (we don't care in the title if it because of a return value or variable assignment). Here it is about fixing flow rule validation, right? One more thing, the word "wrong" can always be avoided after "fix", because we know you are not fixing something which worked perfectly :) Do not hesitate to share these tips around you. Thank you