DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ice: fixed wrong return value
@ 2019-07-09  4:08 Qiming Yang
  2019-07-10  7:29 ` Thomas Monjalon
  2019-07-15  2:23 ` [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail Qiming Yang
  0 siblings, 2 replies; 6+ messages in thread
From: Qiming Yang @ 2019-07-09  4:08 UTC (permalink / raw)
  To: dev; +Cc: Qiming Yang

Fixed error return value check and wrong error message.

Fixes: d76116a4678f ("net/ice: add generic flow API")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/ice/ice_generic_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index d5ff278..e6a2c4b 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
 			rte_flow_error_set(error, EINVAL,
 					   RTE_FLOW_ERROR_TYPE_ACTION,
 					   actions, "Invalid queue ID for"
-					   " ethertype_filter.");
+					   " switch filter.");
 			return -rte_errno;
 		}
 		break;
@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
 	}
 
 	ret = ice_flow_valid_attr(attr, error);
-	if (!ret)
+	if (ret)
 		return ret;
 
 	inset = ice_flow_valid_pattern(pattern, error);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-07-15  5:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09  4:08 [dpdk-dev] [PATCH] net/ice: fixed wrong return value Qiming Yang
2019-07-10  7:29 ` Thomas Monjalon
2019-07-11  2:58   ` Yang, Qiming
2019-07-15  2:23 ` [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail Qiming Yang
2019-07-15  3:19   ` Xing, Beilei
2019-07-15  5:59     ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).