From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Helin Zhang <helin.zhang@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error Date: Mon, 01 Dec 2014 12:12:51 +0100 Message-ID: <2036571.ijmOSAQnXA@xps13> (raw) In-Reply-To: <1417419227-21465-1-git-send-email-helin.zhang@intel.com> 2014-12-01 15:33, Helin Zhang: > The compile error will occur as below when set 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=y'. > The changes is just to fix it. > > lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir: > lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union <anonymous> has no member named fd > lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl [-Werror=unused-variable] > lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh [-Werror=unused-variable] It would be nice to reference the commit which introduced the error and explain it a bit. > - rte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi); > + rte_le_to_cpu_32( > + rxdp->wb.qword3.hi_dword.flex_bytes_hi); [...] > - rte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo); > + rte_le_to_cpu_32( > + rxdp->wb.qword3.lo_dword.flex_bytes_lo); Why are you wrapping these lines (with wrong indentation)? It makes the fix confuse. -- Thomas
next prev parent reply other threads:[~2014-12-01 11:13 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-01 7:33 Helin Zhang 2014-12-01 11:12 ` Thomas Monjalon [this message] 2014-12-02 0:35 ` Zhang, Helin 2014-12-02 6:58 ` Qiu, Michael 2014-12-03 1:13 ` [dpdk-dev] [PATCH v2] i40e: " Helin Zhang 2014-12-03 7:47 ` Wu, Jingjing 2014-12-03 10:03 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2036571.ijmOSAQnXA@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=helin.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git