From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id EF6BB803D
 for <dev@dpdk.org>; Mon,  1 Dec 2014 12:13:34 +0100 (CET)
Received: by mail-wg0-f54.google.com with SMTP id l2so13788656wgh.13
 for <dev@dpdk.org>; Mon, 01 Dec 2014 03:13:34 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=uIP805hgA0k52/FcRUQzTprbEJ1L1tuJnj0uXHfFpTk=;
 b=H+ETry9w2vzx3/PedBM6dIiSsHtZPXiS2SR4GIPP6uWT3XkHyVpuoTixc7JPK1H1Zw
 z8nOwgS6Sq3763TslpulHd5m58uDQOrvjjFYkfBxlq398FlGBbXLO/VCdUwY8AQkRj4Y
 dTA9zY8q7SwmQaGqSUDddrKhs2By5gva3Th1u7fXdHKQHgnBB/e8+4TcxCa3yO7N39+S
 d3fYRB2+Onziq6cLmnXD1+s5Bpi/cw1iSTzCYR9DEy8vcdrDBaqheOPb+iz/DxPAzkCw
 56Owji4JXI4hzweZWzMMXqVXQSzwfUwV6CKoosH84UYlSfls376PrS/J2mfl/PK1fMaR
 nlYQ==
X-Gm-Message-State: ALoCoQmbHhzO0tclKL/Mo/MelUfnnndOeleqpMOkVeccS18YWbWseRX/RqyRMojN1kvw2LKopKeo
X-Received: by 10.180.79.169 with SMTP id k9mr84911155wix.34.1417432414684;
 Mon, 01 Dec 2014 03:13:34 -0800 (PST)
Received: from xps13.localnet (177.17.90.92.rev.sfr.net. [92.90.17.177])
 by mx.google.com with ESMTPSA id e16sm18357404wik.2.2014.12.01.03.13.31
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 01 Dec 2014 03:13:33 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Mon, 01 Dec 2014 12:12:51 +0100
Message-ID: <2036571.ijmOSAQnXA@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1417419227-21465-1-git-send-email-helin.zhang@intel.com>
References: <1417419227-21465-1-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 11:13:35 -0000

2014-12-01 15:33, Helin Zhang:
> The compile error will occur as below when set 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=y'.
> The changes is just to fix it.
> 
> lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir:
> lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union <anonymous> has no member named fd
> lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl [-Werror=unused-variable]
> lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh [-Werror=unused-variable]

It would be nice to reference the commit which introduced the error
and explain it a bit.

> -			rte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi);
> +			rte_le_to_cpu_32(
> +			rxdp->wb.qword3.hi_dword.flex_bytes_hi);
[...]
> -			rte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo);
> +			rte_le_to_cpu_32(
> +			rxdp->wb.qword3.lo_dword.flex_bytes_lo);

Why are you wrapping these lines (with wrong indentation)?
It makes the fix confuse.

-- 
Thomas