From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id D140A2C30; Thu, 17 Jan 2019 18:38:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 3CC671525; Thu, 17 Jan 2019 12:38:36 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 17 Jan 2019 12:38:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EJvD5Es7fV6Jqu/+diBrFyePNhnd2mf7GDee4wDVLuw=; b=eA3ok1Zirgc6 LUiobWjL/zBLcqQU8hQmiD7R4NpTvEpSoD/MVWSzHtOny42o5/F5Sj3ydGuNsGpp u6FL+rosj7YORhCd7nojNO3rvYpjk5eCMUiiK/IJFcvLG1+XK3NZAgl5WF44VxNd WCOW9t7EowiMRHICat6cOS0YEStEtoQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EJvD5Es7fV6Jqu/+diBrFyePNhnd2mf7GDee4wDVL uw=; b=hX5/wGSHFMihP2AZdVh8FuTgKuXzeIO/CFdeTDN8tqum9bYdxlM4Cr9l6 /kwo98kB9/NSFYPE2pPJtcWUUMlnTaehI5aCw9AcCaNBWaf0dvvv7sKTHXqVvyK6 dy8PWLeh4pUpdBnpyeSUz2ZrTpU+4dRmoYH9CfBVAzV2C8Y5xMefLb7kiCh7Mzpx G1+LzFp98yp6+0D9IDmDBLEjQsFN0gP65trsxvEJNdJbRIXJBl2yPCq8nVy3sdAE SKcif886qCUfyw6mcCse2y4sxYO+uVX+DtcPeJo9l8cT04sEJh/wrY3uAlcT98it vJJ4ck8b3OZs17Zjotr2QRdnn0WPw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeekgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1497DE41AC; Thu, 17 Jan 2019 12:38:33 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Bruce Richardson , solal.pirelli@gmail.com, dpdk stable Date: Thu, 17 Jan 2019 18:38:32 +0100 Message-ID: <20373872.tSZagaFhzs@xps> In-Reply-To: References: <1547730777-20405-1-git-send-email-david.marchand@redhat.com> <3463567.oezzxnnWpT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 17:38:38 -0000 17/01/2019 18:17, David Marchand: > On Thu, Jan 17, 2019 at 5:34 PM Thomas Monjalon wrote: > > > 17/01/2019 14:12, David Marchand: > > > In the unlikely case when the dpdk application is started with no cpu > > > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > > > automatically chosen as RTE_MAX_LCORE which triggers an out of bound > > > access. > > > > > > Either you have a crash then, or the initialisation fails later when > > > trying to pin the master thread on it. > > > In my test, with RTE_MAX_LCORE == 2: > > > > > > $ taskset -c 2 ./master/app/testpmd --no-huge -m 512 --log-level *:debug > > > [...] > > > EAL: pthread_setaffinity_np failed > > > PANIC in eal_thread_init_master(): > > > cannot set affinity > > > 7: [./master/app/testpmd() [0x47f629]] > > > > > > Bugzilla ID: 19 > > > Signed-off-by: David Marchand > > > > We should backport this fix. > > When this bug has been introduced? > > > > Indeed, at first, I thought the problem had always been there, but it > should be starting 17.02: > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > > + CC stable > > Do you want a v2 ? Applied, thanks