From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CD43A034E; Thu, 20 Jan 2022 16:01:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D36DA426F7; Thu, 20 Jan 2022 16:01:03 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 2062740042 for <dev@dpdk.org>; Thu, 20 Jan 2022 16:01:02 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D195B3201F82; Thu, 20 Jan 2022 10:01:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 20 Jan 2022 10:01:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=75Wp92LasvutP8 TT8s7hGCSUGJ+yHPgIMWmRh4IF0yg=; b=Rh0CQcQM+DtWlIsFEQ9PsMGt8Z2XMh oqhy/Q0YKFE62ryMJkEoSR3FS4MuxaQQU1+aqo8ik14NKUwgAi0HqZaHqbG/f+cl 7EkG5dTahmAk1bJ5V+7QCB6bzi45anqnHrt6bMCUqc3Jd673T+2A4YwDG/jILM+b kR/lM/mndYzc9Uoq+Qxxty+dlEBpWu9aA5RvyqjBrWitCmLuUVjXFNSrlgXeIlO0 PkXjs6FzIkr8KIRyk9FIcfTkZPqeQZvRHY6iQPZQ9U8e4bssnyAXvgD7HoiN423u NoIKUDZjdZXxMuMGsQORNfIlE3rh8/h+bi9FgrfK/2jq6l2UaVkdNSyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=75Wp92LasvutP8TT8s7hGCSUGJ+yHPgIMWmRh4IF0 yg=; b=QtOlO3P+0E/scN2xEP0SaDONmquDDrFGNEPApa+6hCQxQivMD8EmNejRU jeVXZtJ1iRIRo+OSfz+5hZdUKvwWGOd+H6HcsVpTNLHbjyp+6MUavEJ+zYkYauOj 2BtNY371zRJzkrsUp5S3WZnYlrH+sPOVhMsCTjqv4OnNeh4OUjdb2Iue4Rps36Wf OO092K7jDuX5RtvY0gcSY/Fh44x8agr7S/t4P9F7klCBvZXVDEIsIuCnpOYdWQtV HBMf2RbrNDkApFmFtrtOrGOXImtDMqghVOfbRLNaFZmftWrPRQ0neTS6hC9bgEdv T/JgLJSRtRsSh+vuEgEvTfGrX7CEg== X-ME-Sender: <xms:LHnpYbBoyTEvR8oQ_aGm_fOsoiR6Nv6T-6hdNwMXfVL6Zb6LvTdqLg> <xme:LHnpYRjPBZFmDDHZBLSGVsls2aS9YR3axHQQR3tDJIyvf3V2zSBopC6fpqmdVeerz oCpOU7zHLWakeObog> X-ME-Received: <xmr:LHnpYWkVCalSwamu40AAB4ohIsmH2zfrb206CIh6w7omSUO-mSly61DxKvz0h_dUiH-VbtYo6Suro20XedSFhhDl2Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:LHnpYdzfyTHWj4nfoTw46boERbk7N3Xc_Pf5TgJw-pWKcQP3IZpqeQ> <xmx:LHnpYQS9J_X1-Iwo1Nc8pXub-cVEDHIxm5PSrZ-CJIg0dFwOMJFD3Q> <xmx:LHnpYQavU05meuF9qEQfFYd6TBPaQc0GAJtxFD736nftIxevLiTPFg> <xmx:LHnpYbfm49IA3oUdM8xEps3EJIvxpGdhc7n-Yn0e4BeGfCcgu78Yqg> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jan 2022 10:00:59 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Sean Morrissey <sean.morrissey@intel.com> Cc: dev@dpdk.org, Conor Fogarty <conor.fogarty@intel.com>, Bruce Richardson <bruce.richardson@intel.com> Subject: Re: [PATCH v5 01/50] devtools: script to remove unused headers includes Date: Thu, 20 Jan 2022 16:00:58 +0100 Message-ID: <2037566.htQpZWrp2x@thomas> In-Reply-To: <20220117201943.873922-2-sean.morrissey@intel.com> References: <20220114162409.334437-1-sean.morrissey@intel.com> <20220117201943.873922-1-sean.morrissey@intel.com> <20220117201943.873922-2-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 17/01/2022 21:18, Sean Morrissey: > This script can be used for removing headers flagged for removal by the > include-what-you-use (IWYU) tool. The script has the ability to remove > headers from specified sub-directories or dpdk as a whole and tests the > build after each removal by calling meson compile. > > example usages: > > Remove headers flagged by iwyu_tool output file > $ ./devtools/process_iwyu.py iwyu.out -b build > > Remove headers flagged by iwyu_tool output file from sub-directory > $ ./devtools/process_iwyu.py iwyu.out -b build -d lib/kvargs > > Remove headers directly piped from the iwyu_tool > $ iwyu_tool -p build | ./devtools/process_iwyu.py - -b build Can it be an automatic check per patch? Or are we supposed to run it from time to time? > Signed-off-by: Sean Morrissey <sean.morrissey@intel.com> > Signed-off-by: Conor Fogarty <conor.fogarty@intel.com> > > Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Please no blank line between names. I assume you checked with flake8?