* [dpdk-dev] [PATCH] efd: fix build when compiler does not support AVX2
@ 2017-10-13 18:24 Ferruh Yigit
2017-10-13 20:07 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-13 18:24 UTC (permalink / raw)
To: Ferruh Yigit, Byron Marohn, Pablo de Lara Guarch; +Cc: dev
Compiler error:
irte_efd.o: In function `rte_efd_lookup':
rte_efd.c:(.text+0x6d6e): undefined reference to `efd_lookup_internal_avx2'
rte_efd.o: In function `rte_efd_lookup_bulk':
rte_efd.c:(.text+0x87d4): undefined reference to `efd_lookup_internal_avx2'
This can be observed with a compiler that doesn't support AVX2 and
shared build.
Fixes: 86d898968826 ("efd: add AVX2 vector lookup function")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
lib/librte_efd/rte_efd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c
index 4d9a08876..ba9f0d83c 100644
--- a/lib/librte_efd/rte_efd.c
+++ b/lib/librte_efd/rte_efd.c
@@ -1278,7 +1278,7 @@ efd_lookup_internal(const struct efd_online_group_entry * const group,
switch (lookup_fn) {
-#if defined(RTE_ARCH_X86)
+#if defined(RTE_ARCH_X86) && defined(CC_SUPPORT_AVX2)
case EFD_LOOKUP_AVX2:
return efd_lookup_internal_avx2(group->hash_idx,
group->lookup_table,
--
2.13.6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] efd: fix build when compiler does not support AVX2
2017-10-13 18:24 [dpdk-dev] [PATCH] efd: fix build when compiler does not support AVX2 Ferruh Yigit
@ 2017-10-13 20:07 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-10-13 20:07 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Byron Marohn, Pablo de Lara Guarch
13/10/2017 20:24, Ferruh Yigit:
> Compiler error:
> irte_efd.o: In function `rte_efd_lookup':
> rte_efd.c:(.text+0x6d6e): undefined reference to `efd_lookup_internal_avx2'
> rte_efd.o: In function `rte_efd_lookup_bulk':
> rte_efd.c:(.text+0x87d4): undefined reference to `efd_lookup_internal_avx2'
>
> This can be observed with a compiler that doesn't support AVX2 and
> shared build.
>
> Fixes: 86d898968826 ("efd: add AVX2 vector lookup function")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 20:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 18:24 [dpdk-dev] [PATCH] efd: fix build when compiler does not support AVX2 Ferruh Yigit
2017-10-13 20:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).