From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 1D5C45A76 for ; Tue, 10 Mar 2015 12:20:37 +0100 (CET) Received: by wggy19 with SMTP id y19so975949wgg.9 for ; Tue, 10 Mar 2015 04:20:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=YklMyLtS0aBsI6RGgoQIW04V9/mI+66IRMum7elxO5U=; b=CvUYJx4S+1EbRfCj4kRoLoIqIkXpREVI8MzQ8FtdD1im5CiIjr7ILLvfrTFz01FBZB ijjiHJ9+RWdGZqHVPn7PSQzXEYVXim3ll1wz0Tb5RfLzIjye7R+3UE8/aNcKHs6sF58y zdG6TjXq6WPsyXyw077WHJeOP7EBahyeKSGeXi9e9hEdgm4EV6ocw41bMa/VdNHX5QU8 p3IV4mhVj5Mess3rvJwaULy/KubMLxro/8bp/j7sTdsL0v2P8askDMieHPZhyqohIt5X J3TMmbghpSDX0rWHqgwUYcRIPXeCXdfbdHo0MyDILSSvq49ieiWL3YJXAGAf5vs8kbNP RWLQ== X-Gm-Message-State: ALoCoQmXYiIKw7P5ejIzz7JAGVlC4WbwppTQp10meKiolUZpz0hmviFOudx/wyKzMsnhBB6QBq8J X-Received: by 10.180.21.162 with SMTP id w2mr51575965wie.66.1425986436896; Tue, 10 Mar 2015 04:20:36 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id nb4sm428407wjc.20.2015.03.10.04.20.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2015 04:20:36 -0700 (PDT) From: Thomas Monjalon To: David Marchand Date: Tue, 10 Mar 2015 12:20:02 +0100 Message-ID: <2038190.P10mg0IX0N@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <20150306002636.GA6785@neilslaptop.think-freely.org> References: <1425505810-9269-1-git-send-email-david.marchand@6wind.com> <20150306002636.GA6785@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 11:20:37 -0000 2015-03-05 19:26, Neil Horman: > On Wed, Mar 04, 2015 at 10:50:00PM +0100, David Marchand wrote: > > This is a first cleanup at trying to remove references to other dpdk libraries > > from eal. > > > > This cleanup is focused on rte_tailq api which has been marked as "for internal > > use" for quite some time now. > > Rather than have a static list in eal for all users of rte_tailq, a new register > > system is introduced. > > This register system uses constructors which have no access to dpdk shared > > memory, so a two step registration is done: first step inserts the requested > > tailq in a local list ("local" in multi process context), then in second step, > > eal init allocates/looks up for a real tailq from shared memory for all elements > > of this local list. > > > > I have tried to think of different cases (libraries loaded before/after eal > > init...). The unit tests have been updated accordingly. > > > > > This all seems pretty reasonable. > > It might make sense to add a deprecation notice for this, since its removing > public macros, but since we're not really doing that until the 2.0 release is > out, I think we can skip it > > For the series > Acked-by: Neil Horman Applied, thanks