From: Thomas Monjalon <thomas@monjalon.net>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, hemant.agrawal@nxp.com
Subject: Re: [dpdk-dev] [PATCH] drivers/bus: fill driver reference after NXP probing
Date: Thu, 27 Sep 2018 14:40:32 +0200 [thread overview]
Message-ID: <2039580.JQpZYNxiQt@xps> (raw)
In-Reply-To: <bf85270a-f97a-be27-3ee4-808020cdc366@nxp.com>
26/09/2018 10:12, Shreyansh Jain:
> On Wednesday 26 September 2018 12:52 AM, Thomas Monjalon wrote:
> > The probing functions of NXP buses were missing to set
> > the driver used for successfully probing a device.
> >
> > The NXP driver and the generic rte_driver are now set
> > in the device structures.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> A part of this was already being done in the drv->probe(), though it was
> not complete (dpaa2_dev->driver = dpaa2_drv; was not being done).
>
> --->8---net/dpaa2/dpaa2_ethdev.c--
> 2008
> 2009 eth_dev->device = &dpaa2_dev->device;
> 2010 eth_dev->device->driver = &dpaa2_drv->driver;
> 2011
> --->8---
I guess we could remove the driver assignment in NXP drivers,
after this patch applied.
> Thank you!
>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Applied
next prev parent reply other threads:[~2018-09-27 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 19:22 Thomas Monjalon
2018-09-26 8:12 ` Shreyansh Jain
2018-09-27 12:40 ` Thomas Monjalon [this message]
2018-09-28 12:27 ` Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2039580.JQpZYNxiQt@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).