From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, anatoly.burakov@intel.com,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: fix argument to rte_bsf32_safe
Date: Sat, 24 Jul 2021 09:58:44 +0200 [thread overview]
Message-ID: <2040984.QlECWYl36d@thomas> (raw)
In-Reply-To: <20210723154546.7958-1-stephen@networkplumber.org>
23/07/2021 17:45, Stephen Hemminger:
> The first argument to rte_bsf32_safe was incorrectly declared as
> a 64 bit value. The code only works on 32 bit values and the underlying
> function rte_bsf32 only accepts 32 bit values. This was a mistake
> introduced when the safe version was added and probably cause
> by copy/paste from the 64 bit version.
>
> The bug passed silently under the radar until some other code was
> built with -Wall and -Wextra in C++ and C++ complains about the
> missing cast.
>
> Yes, this is a API signature change, but the original code was wrong.
> It is an inline so not an ABI change.
>
> Fixes: 4e261f551986 ("eal: add 64-bit bsf and 32-bit safe bsf functions")
> Cc: anatoly.burakov@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
+Cc: stable@dpdk.org
Applied, thanks.
I think these functions lack a reference to the name Bit Scan Forward.
next prev parent reply other threads:[~2021-07-24 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 20:12 [dpdk-dev] [PATCH] " Stephen Hemminger
2021-07-19 17:15 ` Tyler Retzlaff
2021-07-19 22:00 ` Stephen Hemminger
2021-07-20 13:26 ` Thomas Monjalon
2021-07-23 0:52 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2021-07-23 15:45 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2021-07-24 7:58 ` Thomas Monjalon [this message]
2021-07-24 23:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2040984.QlECWYl36d@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).