From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 54C68595E for ; Wed, 15 Jul 2015 14:08:01 +0200 (CEST) Received: by wgmn9 with SMTP id n9so31920443wgm.0 for ; Wed, 15 Jul 2015 05:08:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=e6DVSC9H0LqQZdRjNRSaYpg9ff8UVe1ImLJ6oaXNYJ8=; b=Wb5aoCW1oPuudKjt6nVwxTnNGb5IK7CqO+drFmKahh209zvPKSHj04DpkDElj7lEss UMfrAt/f//rolLO/Ns/PNOu6SZJRSEPHHETuAZobvkIgAsI3zI/Im+opSbvyNXO/iBad BL/Kp5e8fB09UA7nON46wOUUk/fBwSHASbZyiKrWiB9lp8/Z+yd0bpkEhhIGq8ccCDuE qON4LuWkDo91/aVZXHR+d/Iowm8602Mpq7QWC/xm7mByBTJCZY5QiznvMsXCxcXuJUaO ckC31rGaf7vpWr02kEu19lW8JQDgXr2pjALDSLgHJf0+CVUmkDv+pT5VEECzumT6n4sy H8Kg== X-Gm-Message-State: ALoCoQmbI8j0+1o23+AGhbLZbsbXHci5V2o/mI3fChf4DCxujdyfYf0oZv7rAg410W+74Bqcixj2 X-Received: by 10.195.11.168 with SMTP id ej8mr7778008wjd.150.1436962081177; Wed, 15 Jul 2015 05:08:01 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id wx9sm7636285wjb.6.2015.07.15.05.07.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 05:07:59 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Wed, 15 Jul 2015 14:06:48 +0200 Message-ID: <2041754.gAIZiEM3Hs@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1436962741.PL5XZBfjSs@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support access device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 12:08:01 -0000 2015-07-15 11:36, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-15 10:48, Wang, Liang-min: > > > > > > What means magic? Is it always a device id? > > > > > This field is the same as defined in kernel ethtool data structure. > > > > > > > > Not an excellent argument :) > > > > Actually you didn't answer. > > > > > > > I could not speak for other devices. For igb and ixgbe, it's device id. > > > Based upon literature search, this field is used by device driver to provide > > extra information. > > > What would be your suggestion? > > > > I don't have any suggestion. > > You are defining a new API in DPDK, so our concern must be to check > > that it will be easily understood by users and PMD developers. > > If you don't really know what this field will be for, others won't know. > No, I meant it's device driver dependent. > If I keep the same naming convention following kernel ethtool defined, > and adding comment like "device-specific magic key, such as device-id". > Would that be acceptable from you? OK > This data structure is defined to be compatible with kernel ethtool API, > and magic key is device specific and known to ethtool API users.